public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Dilip Kumar <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Adding facility for injection points (or probe points?) for more advanced tests
Date: Mon, 11 Dec 2023 18:44:46 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFiTN-u+xrjmgK+3-TCjug_kqwWwUB3CXiOVjXNE1=vcf4JRUQ@mail.gmail.com>
References: <[email protected]>
	<CAExHW5vZXq8WiTFiCfzk-f7Sqi+TMZ0Ty6XxehUZ9o91GP_AJA@mail.gmail.com>
	<[email protected]>
	<CAExHW5skzA6UPEYALz4GkCZdJZBt94uWahp5fExu09S90e1iHQ@mail.gmail.com>
	<[email protected]>
	<CAExHW5usVs10M4i5RD68r5fpbr3mdzePnT589nT4X3cm7L64sQ@mail.gmail.com>
	<[email protected]>
	<CAExHW5vyURNaht1YYJfZMk-Kyh=TD6FhE4NEi5zTAhnOj0qwcA@mail.gmail.com>
	<[email protected]>
	<CAFiTN-u+xrjmgK+3-TCjug_kqwWwUB3CXiOVjXNE1=vcf4JRUQ@mail.gmail.com>

On Mon, Dec 11, 2023 at 11:09:45AM +0530, Dilip Kumar wrote:
> I haven't specifically done a review or testing of this patch, but I
> have used this for testing the CLOG group update code with my
> SLRU-specific changes and I found it quite helpful to test some of the
> concurrent areas where you need to stop processing somewhere in the
> middle of the code and testing that area without this kind of
> injection point framework is really difficult or may not be even
> possible.  We wanted to test the case of clog group update where we
> can get multiple processes added to a single group and get the xid
> status updated by the group leader, you can refer to my test in that
> thread[1] (the last patch test_group_commit.patch is using this
> framework for testing).

Could you be more specific?  test_group_commit.patch includes this
line but there is nothing specific about this injection point getting
used in a test or a callback assigned to it:
./test_group_commit.patch:+	INJECTION_POINT("ClogGroupCommit");

> Overall I feel this framework is quite useful
> and easy to use as well.

Cool, thanks.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Adding facility for injection points (or probe points?) for more advanced tests
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox