public inbox for [email protected]  

help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Noah Misch <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Robert Pang <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after a crash
Date: Sat, 5 Apr 2025 19:14:27 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <Z2L6e1w-xABVTBRR@nathan>
	<7chjz7zeigbsbt7nim4cj6zryflzcpy2lgenas3yh7cpvwf3gb@m6cwqzlvfd6q>
	<[email protected]>
	<[email protected]>
	<Z8n7HopB0bb4_j19@nathan>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Wed, Apr 02, 2025 at 05:29:00PM -0700, Noah Misch wrote:
> Your back-patches are correct.  Thanks.

Thanks for double-checking.  I'll move on with what I have after a
second look as it's been a few weeks since I've looked at all these
conflicts.  I am also planning to add a few notes in the commits to
mention this thread.

> Here it is.  Making it fail three times took looping 1383s, 5841s, and 2594s.
> Hence, it couldn't be expected to catch the regression before commit, but it
> would have made sufficient buildfarm and CI noise in the day after commit.

Hmm.  Not much of a fan of the addition of a test that has less than
1% of reproducibility for the problem, even if it's good to see that
this can be made portable to run down to v13.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (17+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after a crash
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox