pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: introduce dynamic shared memory registry
Date: Mon, 22 Jan 2024 16:52:52 +0900
Message-ID: <Za4e1CgrLwuOHc7e@paquier.xyz> (raw)
In-Reply-To: <20240121221320.GA1682397@nathanxps13>
References: <20240112172152.GA3803561@nathanxps13>
	<ZaF6UpYImGqVIhVp@toroid.org>
	<20240112194555.GA3804945@nathanxps13>
	<20240113214124.GA4162765@nathanxps13>
	<CALj2ACVKFPm7nCrHMko7JJpsFJU23abzYyMS8S2Pz8r4M=rW7w@mail.gmail.com>
	<20240116160748.GB100542@nathanxps13>
	<CALj2ACWuiAm7Rr13PFfaiQfOHUoCbJOJvU72jyLnj4xfoEOAEg@mail.gmail.com>
	<20240119204636.GA1178173@nathanxps13>
	<3348869.1705854106@sss.pgh.pa.us>
	<20240121221320.GA1682397@nathanxps13>

On Sun, Jan 21, 2024 at 04:13:20PM -0600, Nathan Bossart wrote:
> Oops.  I've attached an attempt at fixing this.  I took the opportunity to
> clean up the surrounding code a bit.

Thanks for the patch.  Your proposed attempt looks correct to me with
an ERROR when no segments are found..
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (51+ messages)  latest in thread

Message-ID: <Za4e1CgrLwuOHc7e@paquier.xyz>
Permalink:  ../Za4e1CgrLwuOHc7e@paquier.xyz/
Also on:    postgresql.org/message-id/Za4e1CgrLwuOHc7e@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, nathandbossart@gmail.com, tgl@sss.pgh.pa.us, bharath.rupireddyforpostgres@gmail.com, ams@toroid.org, robertmhaas@gmail.com
  Subject: Re: introduce dynamic shared memory registry
  In-Reply-To: <Za4e1CgrLwuOHc7e@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox