From: Michael Paquier <michael@paquier.xyz>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack
Date: Mon, 26 Feb 2024 08:37:20 +0900
Message-ID: <ZdvPMIvz90dfQ4ws@paquier.xyz> (raw)
In-Reply-To: <CAPmGK17=Asbxv5Bka3SC==yG1q+1MGV9LA6sb_DqLUG7AxbBAQ@mail.gmail.com>
References: <425fa29a429b21b0332737c42a4fdc70@postgrespro.ru>
<ZdlBFS25eKruiQvO@paquier.xyz>
<CAPmGK17=Asbxv5Bka3SC==yG1q+1MGV9LA6sb_DqLUG7AxbBAQ@mail.gmail.com>
On Sun, Feb 25, 2024 at 06:34:30PM +0900, Etsuro Fujita wrote:
> I think this would happen when FDWs configure no events; IIRC I think
> while the core allows them to do so, postgres_fdw does not do so, so
> this would never happen with it. Anyway, thanks for the report and
> patch, Alexander!
I don't see how that's directly your fault as this is a thinko in the
set of commits 481d7d1c01, 555276f859 and 501cfd07da that have hit
14~16, ignoring entirely the TRY/CATCH block.
Anyway, if you want to address it yourself, feel free to go ahead,
thanks! I would have done it but I've been busy with life stuff for
the last couple of days.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZdvPMIvz90dfQ4ws@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, etsuro.fujita@gmail.com, a.pyhalov@postgrespro.ru
Subject: Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack
In-Reply-To: <ZdvPMIvz90dfQ4ws@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox