From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Subject: Re: Injection points: some tools to wait and wake
Date: Mon, 4 Mar 2024 14:27:22 +0900
Message-ID: <ZeVbugAp1eXCvllA@paquier.xyz> (raw)
In-Reply-To: <CAGECzQQB0YwoCo8za5DSs1zNyMPHLiz5jwOi-xRhe5517qNugA@mail.gmail.com>
References: <Zd7Quc2JXdUg2tar@ip-10-97-1-34.eu-west-3.compute.internal>
<ZeAch9AYrH7UGlCn@paquier.xyz>
<ZeBB4RMPEZ06TcdY@ip-10-97-1-34.eu-west-3.compute.internal>
<9F7DF199-11E0-47D3-B7AE-379EFC6109C2@yandex-team.ru>
<ZeBaXWgYZRkOVY1m@ip-10-97-1-34.eu-west-3.compute.internal>
<BA18A010-60B4-4FAA-AC56-AC95793A5A04@yandex-team.ru>
<ZeE3GTbamjlN1RrP@paquier.xyz>
<ZeF7Pct9eJaN6z5N@ip-10-97-1-34.eu-west-3.compute.internal>
<ZeUngiC5Wzi_LiYH@paquier.xyz>
<CAGECzQQB0YwoCo8za5DSs1zNyMPHLiz5jwOi-xRhe5517qNugA@mail.gmail.com>
On Mon, Mar 04, 2024 at 05:17:52AM +0100, Jelte Fennema-Nio wrote:
> I noticed this was committed, and took a quick look. It sounds very
> useful for testing Citus to be able to use injection points too, but I
> noticed this code is included in src/test/modules. It sounds like that
> location will make it somewhat hard to install. If that's indeed the
> case, would it be possible to move it to contrib instead?
One problem with installing that in contrib/ is that it would require
more maintenance as a stable and "released" module. The aim of this
module is to be more flexible than that, so as it is possible to
extend it at will even in the back branches to be able to implement
features that could help with tests that we'd want to implement in
stable branches. I have mentioned that on a separate thread, but
adding more extension maintenance burden while implementing complex
tests does not sound like a good idea for me in the long-run.
Perhaps we could consider that as an exception in "contrib", or have a
separate path for test modules we're OK to install (the calls had
better be superuser-only if we do that). Another thing with the
backend support of injection points is that you could implement your
own extension within citus, able to do what you mimic this in-core
module, and get inspiration from it. Duplication is never cool, I
agree, though.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, postgres@jeltef.nl, bertranddrouvot.pg@gmail.com, x4mmm@yandex-team.ru, pgsql-hackers@lists.postgresql.org, ashutosh.bapat.oss@gmail.com
Subject: Re: Injection points: some tools to wait and wake
In-Reply-To: <ZeVbugAp1eXCvllA@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox