pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Weird test mixup
Date: Mon, 13 May 2024 07:35:48 +0900
Message-ID: <ZkFERI9JC62kchwC@paquier.xyz> (raw)
In-Reply-To: <20240512174851.b9.nmisch@google.com>
References: <20240506212324.2e.nmisch@google.com>
	<ZjmBPeB6LQeHVHZ7@paquier.xyz>
	<20240507185310.d3@rfd.leadboat.com>
	<Zjwa4lX6wADRAili@paquier.xyz>
	<20240509031553.47@rfd.leadboat.com>
	<ZjxVcbsIy4tq3uhV@paquier.xyz>
	<Zjx9-2swyNg6E1y1@paquier.xyz>
	<20240509233900.4e.nmisch@google.com>
	<Zj1ykS1EsakW_niW@paquier.xyz>
	<20240512174851.b9.nmisch@google.com>

On Sun, May 12, 2024 at 10:48:51AM -0700, Noah Misch wrote:
> This looks correct, and it works well in my tests.  Thanks.

Thanks for looking.  While looking at it yesterday I've decided to
split the change into two commits, one for the infra and one for the
module.  While doing so, I've noticed that the case of a private area
passed as NULL was not completely correct as memcpy would be
undefined.

The open item has been marked as fixed.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (52+ messages)  latest in thread

Message-ID: <ZkFERI9JC62kchwC@paquier.xyz>
Permalink:  ../ZkFERI9JC62kchwC@paquier.xyz/
Also on:    postgresql.org/message-id/ZkFERI9JC62kchwC@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, noah@leadboat.com, hlinnaka@iki.fi, tgl@sss.pgh.pa.us
  Subject: Re: Weird test mixup
  In-Reply-To: <ZkFERI9JC62kchwC@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox