public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Will Mortensen <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Jingxian Li <[email protected]>
Cc: andres <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] LockAcquireExtended improvement
Date: Sat, 18 May 2024 20:37:35 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAMpnoC7uymaewKschMUy5703xfi31ivjZiFKyurjQ=MWqLnP-Q@mail.gmail.com>
References: <[email protected]>
<CA+TgmoYhmf14R9DPfdqx-ym+YV8dzMfwDR+e2qrj07BJ8=bz0Q@mail.gmail.com>
<[email protected]>
<CA+TgmoaYwx7iCfB88xRykMTTORA+1MYkczzmykt4=W=DYTyKMw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmoaZNzNywg+jBXOYcsYbF5gdcY8+y5P5FofEEs6uyaN7_A@mail.gmail.com>
<CA+TgmoYc56fSB-CcO3dJiwEAT8DP6ybmQS0+xb3ucWVMXjTXHw@mail.gmail.com>
<CAMpnoC5f+eiS7tdy8PUpd_LacSTVT-pYpVooKfjHRQQmkHPZ2g@mail.gmail.com>
<CAMpnoC7uymaewKschMUy5703xfi31ivjZiFKyurjQ=MWqLnP-Q@mail.gmail.com>
On Fri, May 17, 2024 at 11:38:35PM -0700, Will Mortensen wrote:
> On Tue, Mar 26, 2024 at 7:14 PM Will Mortensen <[email protected]> wrote:
>> This comment on ProcSleep() seems to have the values of dontWait
>> backward (double negatives are tricky):
>>
>> * Result: PROC_WAIT_STATUS_OK if we acquired the lock,
>> PROC_WAIT_STATUS_ERROR
>> * if not (if dontWait = true, this is a deadlock; if dontWait = false, we
>> * would have had to wait).
>>
>> Also there's a minor typo in a comment in LockAcquireExtended():
>>
>> * Check the proclock entry status. If dontWait = true, this is an
>> * expected case; otherwise, it will open happen if something in the
>> * ipc communication doesn't work correctly.
>>
>> "open" should be "only".
>
> Here's a patch fixing those typos.
Perhaps, this, err.. Should not have been named "dontWait" but
"doWait" ;)
Anyway, this goes way back in time and it is deep in the stack
(LockAcquireExtended, etc.) so it is too late to change: the patch
should be OK as it is.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] LockAcquireExtended improvement
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox