From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: kuroda.hayato@fujitsu.com, shlok.kyal.oss@gmail.com, pgsql-hackers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows
Date: Tue, 4 Jun 2024 08:30:19 +0900
Message-ID: <Zl5SC_kboY7i0AS8@paquier.xyz> (raw)
In-Reply-To: <CA+TgmoZt44PEeX_=5D7RtpKShPckMyZ9+xQkTnrKU5rnZWjfpQ@mail.gmail.com>
References: <20231024.172536.511643991820398116.horikyota.ntt@gmail.com>
<CA+TgmoaYOON0cQPR0Aj_ZD2005+sschuMisSQV7xPqzxrx7vaQ@mail.gmail.com>
<ZZyV99g76Q3-YwEn@paquier.xyz>
<20240111.173322.1809044112677090191.horikyota.ntt@gmail.com>
<CA+TgmoZt44PEeX_=5D7RtpKShPckMyZ9+xQkTnrKU5rnZWjfpQ@mail.gmail.com>
On Mon, Jan 15, 2024 at 01:34:46PM -0500, Robert Haas wrote:
> This kind of change looks massively helpful to me. I don't know if it
> is exactly right or not, but it would have been a big help to me when
> writing my previous review, so +1 for some change of this general
> type.
During a live review of this patch last week, as part of the Advanced
Patch Workshop of pgconf.dev, it has been mentioned by Tom that we may
be able to simplify the check on pmstart if the detection of the
postmaster PID started by pg_ctl is more stable using the WIN32
internals that this patch relies on. I am not sure that this
suggestion is right, though, because we should still care about the
clock skew case as written in the surrounding comments? Even if
that's OK, I would assume that this should be an independent patch,
written on top of the proposed v6-0001.
Tom, could you comment about that? Perhaps my notes did not catch
what you meant.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../Zl5SC_kboY7i0AS8@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, robertmhaas@gmail.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows
In-Reply-To: <Zl5SC_kboY7i0AS8@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox