From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: postgres@jeltef.nl
Cc: smithpb2250@gmail.com
Cc: vignesh21@gmail.com
Cc: jakub.wartak@enterprisedb.com
Cc: stark.cfm@gmail.com
Cc: hlinnaka@iki.fi
Cc: barwick@gmail.com
Cc: jchampion@timescale.com
Cc: pryzby@telsasoft.com
Cc: tgl@sss.pgh.pa.us
Cc: rjuju123@gmail.com
Cc: jakub.wartak@tomtom.com
Cc: pgsql-hackers@lists.postgresql.org
Cc: bharath.rupireddyforpostgres@gmail.com
Subject: Re: In-placre persistance change of a relation
Date: Wed, 5 Jun 2024 13:52:21 +0900
Message-ID: <Zl_vBVP4dNMCu1vb@paquier.xyz> (raw)
In-Reply-To: <Zl9-K3a0-AW4WZrl@nathan>
References: <20240524.160916.2199777355532445323.horikyota.ntt@gmail.com>
<CAGECzQRQzpE-EzJszHHvku1JLw+opu+KxE7rBqfyTmmgFwxrRQ@mail.gmail.com>
<Zl5bKIdOWiHHb-9N@paquier.xyz>
<20240604.160032.391318120410028809.horikyota.ntt@gmail.com>
<Zl9-K3a0-AW4WZrl@nathan>
On Tue, Jun 04, 2024 at 03:50:51PM -0500, Nathan Bossart wrote:
> Bharath, does the multi-INSERT stuff apply when changing a table to be
> LOGGED? If so, I think it would be interesting to compare it with the FPI
> approach being discussed here.
The answer to this question is yes AFAIK. Look at patch 0002 in the
latest series posted here, that touches ATRewriteTable() in
tablecmds.c where the rewrite happens should a relation's
relpersistence, AM, column or default requires a switch (particularly
if more than one property is changed in a single command, grep for
AT_REWRITE_*):
https://www.postgresql.org/message-id/CALj2ACUz5+_YNEa4ZY-XG960_oXefM50MjD71VgSCAVDkF3bzQ@mail.gmail...
I've just read through the patch set, and they are rather pleasant to
the eye. I have comments about them, actually, but that's a topic for
the other thread.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, horikyota.ntt@gmail.com, postgres@jeltef.nl, smithpb2250@gmail.com, vignesh21@gmail.com, jakub.wartak@enterprisedb.com, stark.cfm@gmail.com, hlinnaka@iki.fi, barwick@gmail.com, jchampion@timescale.com, pryzby@telsasoft.com, tgl@sss.pgh.pa.us, rjuju123@gmail.com, jakub.wartak@tomtom.com, pgsql-hackers@lists.postgresql.org, bharath.rupireddyforpostgres@gmail.com
Subject: Re: In-placre persistance change of a relation
In-Reply-To: <Zl_vBVP4dNMCu1vb@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox