pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: jian he <jian.universality@gmail.com>
Cc: Joseph Koshakow <koshy44@gmail.com>
Cc: Matthew Kim <matthewkmkim@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: Remove dependence on integer wrapping
Date: Wed, 14 Aug 2024 14:38:59 -0500
Message-ID: <Zr0H04P1XBjgbyVg@nathan> (raw)
In-Reply-To: <d33f2c31-1fcf-44be-8a39-686c524a389c@iki.fi>
References: <CAAvxfHckS2181hMcr+N2HehUa-HuN-fyJV3WGfth=8tSZGQb-g@mail.gmail.com>
	<CAGzNdfF-nbL=-2vP=pCynn0-2kwTt3wW96dctdJYveeOWrvY1A@mail.gmail.com>
	<CACJufxHNwqoXoP91a-2D3NytrurTSK_+-hd+XeVCYAbk2F0Uhw@mail.gmail.com>
	<CAAvxfHfuxiMG4_YB5oBmJtK7mQx6FRKcUhNueXGwKT6_r=4W_Q@mail.gmail.com>
	<CACJufxFUKTQx8wUpxtRPT31D+a7fNxAL_A_-S4XaR-oZkKEgxA@mail.gmail.com>
	<ZrvUOkL19KHEH2sb@nathan>
	<ZrwfgNyDXy99NUOS@nathan>
	<875ad3ec-f216-487e-baad-cdbaf32c1fcf@iki.fi>
	<ZrznaJTIOPgSjEJ7@nathan>
	<d33f2c31-1fcf-44be-8a39-686c524a389c@iki.fi>

On Wed, Aug 14, 2024 at 10:29:39PM +0300, Heikki Linnakangas wrote:
> Hmm, that still doesn't say what operation it's referring to. They existing
> comments say "a + b", "a - b" or "a * b", but this one isn't referring to
> anything at all. IMHO the existing comments are not too clear on that either
> though. How about something like this:

Yeah, this crossed my mind, too.  I suppose now is as good a time as any to
improve it.  Your suggestion looks good to me, so I will modify the patch
accordingly before committing.

-- 
nathan





view thread (85+ messages)  latest in thread

Message-ID: <Zr0H04P1XBjgbyVg@nathan>
Permalink:  ../Zr0H04P1XBjgbyVg@nathan/
Also on:    postgresql.org/message-id/Zr0H04P1XBjgbyVg@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, hlinnaka@iki.fi, jian.universality@gmail.com, koshy44@gmail.com, matthewkmkim@gmail.com, exclusion@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, andres@anarazel.de
  Subject: Re: Remove dependence on integer wrapping
  In-Reply-To: <Zr0H04P1XBjgbyVg@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox