pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Restart pg_usleep when interrupted
Date: Fri, 9 Aug 2024 14:03:55 -0500
Message-ID: <ZrZoG3uZmUOgbHOv@nathan> (raw)
In-Reply-To: <ZrUkELsJs3CI896W@nathan>
References: <ZqNd7WfTm3sUCpjy@ip-10-97-1-34.eu-west-3.compute.internal>
	<33287B8A-3CA0-494F-87D3-C9D85C6468FE@gmail.com>
	<ZqiIxptiTDqRTxDx@ip-10-97-1-34.eu-west-3.compute.internal>
	<19E276C9-2C2B-435A-B275-8FA22222AEB8@gmail.com>
	<ZrHmE3zUSNXzoHCU@ip-10-97-1-34.eu-west-3.compute.internal>
	<50E1D6AD-3E51-4E45-95A7-7B20DC037DCB@gmail.com>
	<ZrMNlUd1h09nMrNQ@ip-10-97-1-34.eu-west-3.compute.internal>
	<ZrOGi8RZTSHxTq9W@nathan>
	<D1558DDA-CEED-4CED-B3ED-C425D996FCA3@gmail.com>
	<ZrUkELsJs3CI896W@nathan>

On Thu, Aug 08, 2024 at 03:01:20PM -0500, Nathan Bossart wrote:
> Thanks.  This one looks pretty good to me, and so I plan to commit it in
> the near future unless anyone voices concerns about the approach.

As I am preparing this for commit, I'm wondering whether it makes sense to
name the new function vacuum_sleep() and keep it private to vacuum.c.
Nothing about this function is terribly specific to vacuum, and it's not
inconceivable that it might be useful elsewhere.  Perhaps we should move it
to pgsleep.c and rename it to something to the effect of
pg_usleep_non_interruptable().

-- 
nathan





view thread (73+ messages)  latest in thread

Message-ID: <ZrZoG3uZmUOgbHOv@nathan>
Permalink:  ../ZrZoG3uZmUOgbHOv@nathan/
Also on:    postgresql.org/message-id/ZrZoG3uZmUOgbHOv@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, samimseih@gmail.com, bertranddrouvot.pg@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
  Subject: Re: Restart pg_usleep when interrupted
  In-Reply-To: <ZrZoG3uZmUOgbHOv@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox