pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: tgl@sss.pgh.pa.us
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Date: Tue, 15 Oct 2024 12:54:27 -0400
Message-ID: <Zw6eQxtpXIccYpOQ@momjian.us> (raw)
In-Reply-To: <20241015101036.d8c29e4aada1c3e92ddcef9d@sraoss.co.jp>
References: <2565921.1728531809@sss.pgh.pa.us>
	<20241010.160041.949661508167788393.ishii@postgresql.org>
	<20241011114122.c90f8a871462da36f2e2afeb@sraoss.co.jp>
	<20241011.121650.2077607600187658573.ishii@postgresql.org>
	<20241011123653.09a67d3ad7b60a59e4558403@sraoss.co.jp>
	<Zw1rf7vm3FqpItw4@momjian.us>
	<Zw1_j_jofafQbNKl@momjian.us>
	<20241015101036.d8c29e4aada1c3e92ddcef9d@sraoss.co.jp>

On Tue, Oct 15, 2024 at 10:10:36AM +0900, Yugo NAGATA wrote:
> Hi Bruce,
> 
> On Mon, 14 Oct 2024 16:31:11 -0400
> Bruce Momjian <bruce@momjian.us> wrote:
> 
> > On Mon, Oct 14, 2024 at 03:05:35PM -0400, Bruce Momjian wrote:
> > > I did some more research and we able to clarify our behavior in
> > > release.sgml:
> > 
> > I have specified some more details in my patched version:
> > 
> >         We can only use Latin1 characters, not all UTF8 characters,
> >         because some rendering engines do not support non-Latin1 UTF8
> >         characters.  Specifically, the HTML rendering engine can display
> >         all UTF8 characters, but the PDF rendering engine can only display
> >         Latin1 characters.  In PDF files, non-Latin1 UTF8 characters are
> >         displayed as "###".
> > 
> >         In the SGML files we encode non-ASCII Latin1 characters as HTML
> >         entities, e.g., &Aacute;lvaro.  Oddly, it is possible to safely
> >         represent Latin1 characters in SGML files as UTF8 for HTML and
> >         PDF output, but we we currently disallow this via the Makefile
> >         "check-non-ascii" rule.
> > 
> 
> I agree with encoding non-Latin1 characters and disallowing non-ASCII
> characters totally.
> 
> I found your patch includes fixes in *.svg files, so how about checking
> also them by check-non-ascii? Also, I think it is better to use perl instead
> of grep because non-GNU grep doesn't support hex escape sequences. I've attached
> a updated patch for Makefile. The changes in release.sgml above is not applied
> yet, though.

Yes, good idea on using Perl and checking svg files --- I have used your
Makefile rule.

Attached is an updated patch.  I realized that the new rules apply to
all SGML files, not just the release notes, so I have created
README.non-ASCII and moved the description there.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

Attachments:

latin1.diff (text/x-diff, 9.6K) download diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile index 65ed32cd0ab..a3ff1168729 100644 --- a/doc/src/sgml/Makefile +++ b/doc/src/sgml/Makefile @@ -143,11 +143,12 @@ postgres.txt: postgres.html ## Print ## -postgres.pdf: +postgres.pdf pdf: $(error Invalid target; use postgres-A4.pdf or postgres-US.pdf as targets) XSLTPROC_FO_FLAGS += --stringparam img.src.path '$(srcdir)/' +# XSL Formatting Objects (FO), https://en.wikipedia.org/wiki/XSL_Formatting_Objects %-A4.fo: stylesheet-fo.xsl %-full.xml $(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(XSLTPROC_FO_FLAGS) --stringparam paper.type A4 -o $@ $^ @@ -194,7 +195,7 @@ MAKEINFO = makeinfo ## # Quick syntax check without style processing -check: postgres.sgml $(ALLSGML) check-tabs check-nbsp +check: postgres.sgml $(ALLSGML) check-tabs check-non-ascii $(XMLLINT) $(XMLINCLUDE) --noout --valid $< @@ -262,10 +263,10 @@ check-tabs: # Non-breaking spaces are harmless, but it is best to avoid them in SGML files. # Use perl command because non-GNU grep or sed could not have hex escape sequence. -check-nbsp: - @ ( $(PERL) -ne '/\xC2\xA0/ and print("$$ARGV:$$_"),$$n++; END {exit($$n>0)}' \ - $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml $(srcdir)/*.xsl) ) || \ - (echo "Non-breaking spaces appear in SGML/XML files" 1>&2; exit 1) +check-non-ascii: + @ ( $(PERL) -ne '/[^\x00-\x7f]/ and print("$$ARGV: $$_"), $$n++; END { exit($$n > 0) }' \ + $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml $(srcdir)/*.xsl $(srcdir)/images/*.svg) ) || \ + (echo "Non-ASCII characters appear in SGML/XML files; use HTML entities for Latin1 characters" 1>&2; exit 1) ## ## Clean diff --git a/doc/src/sgml/README.non-ASCII b/doc/src/sgml/README.non-ASCII new file mode 100644 index 00000000000..a7300bcb2d3 --- /dev/null +++ b/doc/src/sgml/README.non-ASCII @@ -0,0 +1,38 @@ +<!-- doc/src/sgml/README.non-ASCII --> + +Representation of non-ASCII characters +-------------------------------------- + +Find non-ASCII characters using: + + grep --color='auto' -P "[\x80-\xFF]" + +Convert to HTML4 named entity (&) escapes +----------------------------------------- + +We support several output formats: + +* html (supports all Unicode characters) +* man (supports all Unicode characters) +* pdf (supports only Latin-1 characters) +* info + +While some output formatting tools support all Unicode characters, +others only support Latin-1 characters. Specifically, the PDF rendering +engine can only display Latin-1 characters; non-Latin-1 Unicode +characters are displayed as "###". + +Therefore, in the SGML files, we only use Latin-1 characters. We encode +these characters as HTML entities, e.g., &Aacute;lvaro. Oddly, in SGML +files it is possible to safely represent Latin-1 characters in UTF8 +encoding for all output formats, but we we currently disallow this via +the Makefile rule "check-non-ascii". + +Do not use UTF numeric character escapes (&#nnn;). + +HTML entities + official: http://www.w3.org/TR/html4/sgml/entities.html + one page: http://www.zipcon.net/~swhite/docs/computers/browsers/entities_page.html + other lists: http://www.zipcon.net/~swhite/docs/computers/browsers/entities.html + http://www.zipcon.net/~swhite/docs/computers/browsers/entities_page.html + https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml index 1ef5322b912..f5e115e8d6e 100644 --- a/doc/src/sgml/charset.sgml +++ b/doc/src/sgml/charset.sgml @@ -1225,7 +1225,7 @@ CREATE COLLATION ignore_accents (provider = icu, locale = 'und-u-ks-level1-kc-tr <programlisting> -- ignore differences in accents and case CREATE COLLATION ignore_accent_case (provider = icu, deterministic = false, locale = 'und-u-ks-level1'); -SELECT 'Å' = 'A' COLLATE ignore_accent_case; -- true +SELECT '&Aring;' = 'A' COLLATE ignore_accent_case; -- true SELECT 'z' = 'Z' COLLATE ignore_accent_case; -- true -- upper case letters sort before lower case. @@ -1282,7 +1282,7 @@ SELECT 'w;x*y-z' = 'wxyz' COLLATE num_ignore_punct; -- true <entry><literal>'ab' = U&amp;'a\2063b'</literal></entry> <entry><literal>'x-y' = 'x_y'</literal></entry> <entry><literal>'g' = 'G'</literal></entry> - <entry><literal>'n' = 'ñ'</literal></entry> + <entry><literal>'n' = '&ntilde;'</literal></entry> <entry><literal>'y' = 'z'</literal></entry> </row> </thead> @@ -1346,7 +1346,7 @@ SELECT 'w;x*y-z' = 'wxyz' COLLATE num_ignore_punct; -- true <para> At every level, even with full normalization off, basic normalization is - performed. For example, <literal>'á'</literal> may be composed of the + performed. For example, <literal>'&aacute;'</literal> may be composed of the code points <literal>U&amp;'\0061\0301'</literal> or the single code point <literal>U&amp;'\00E1'</literal>, and those sequences will be considered equal even at the <literal>identic</literal> level. To treat @@ -1430,8 +1430,8 @@ SELECT 'x-y' = 'x_y' COLLATE level4; -- false <entry><literal>false</literal></entry> <entry> Backwards comparison for the level 2 differences. For example, - locale <literal>und-u-kb</literal> sorts <literal>'àe'</literal> - before <literal>'aé'</literal>. + locale <literal>und-u-kb</literal> sorts <literal>'&agrave;e'</literal> + before <literal>'a&eacute;'</literal>. </entry> </row> diff --git a/doc/src/sgml/images/genetic-algorithm.svg b/doc/src/sgml/images/genetic-algorithm.svg index fb9fdd1ba78..2ce5f1b2712 100644 --- a/doc/src/sgml/images/genetic-algorithm.svg +++ b/doc/src/sgml/images/genetic-algorithm.svg @@ -72,7 +72,7 @@ <title>a4-&gt;end</title> <path fill="none" stroke="#000000" d="M259,-312.5834C259,-312.5834 259,-54.659 259,-54.659"/> <polygon fill="#000000" stroke="#000000" points="262.5001,-54.659 259,-44.659 255.5001,-54.6591 262.5001,-54.659"/> -<text text-anchor="middle" x="246" y="-186.6212" font-family="sans-serif" font-size="10.00" fill="#000000">true  </text> +<text text-anchor="middle" x="246" y="-186.6212" font-family="sans-serif" font-size="10.00" fill="#000000">true</text> </g> <!-- a5 --> <g id="node7" class="node"> @@ -85,7 +85,7 @@ <title>a4-&gt;a5</title> <path fill="none" stroke="#000000" d="M144,-298.269C144,-298.269 144,-286.5248 144,-286.5248"/> <polygon fill="#000000" stroke="#000000" points="147.5001,-286.5248 144,-276.5248 140.5001,-286.5249 147.5001,-286.5248"/> -<text text-anchor="middle" x="127" y="-284.3969" font-family="sans-serif" font-size="10.00" fill="#000000">false   </text> +<text text-anchor="middle" x="127" y="-284.3969" font-family="sans-serif" font-size="10.00" fill="#000000">false</text> </g> <!-- a6 --> <g id="node8" class="node"> diff --git a/doc/src/sgml/release.sgml b/doc/src/sgml/release.sgml index 8433690dead..cee577ff8d3 100644 --- a/doc/src/sgml/release.sgml +++ b/doc/src/sgml/release.sgml @@ -16,24 +16,6 @@ pg_[A-Za-z0-9_]+ <application>, <structname> \<[a-z]+_[a-z_]+\> <varname>, <structfield> <systemitem class="osname"> -non-ASCII characters find using grep -P '[\x80-\xFF]' or - (remove 'X') grep -X-color='auto' -P -n "[\x80-\xFF]" - convert to HTML4 named entity (&) escapes - - official: http://www.w3.org/TR/html4/sgml/entities.html - one page: http://www.zipcon.net/~swhite/docs/computers/browsers/entities_page.html - other lists: http://www.zipcon.net/~swhite/docs/computers/browsers/entities.html - http://www.zipcon.net/~swhite/docs/computers/browsers/entities_page.html - https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references - - We cannot use UTF8 because rendering engines have to - support the referenced characters. - - Do not use numeric _UTF_ numeric character escapes (&#nnn;), - we can only use Latin1. - - Example: Alvaro Herrera is &Aacute;lvaro Herrera - wrap long lines For new features, add links to the documentation sections. diff --git a/doc/src/sgml/stylesheet-man.xsl b/doc/src/sgml/stylesheet-man.xsl index fcb485c2931..2e2564da683 100644 --- a/doc/src/sgml/stylesheet-man.xsl +++ b/doc/src/sgml/stylesheet-man.xsl @@ -213,12 +213,12 @@ <!-- Slight rephrasing to indicate that missing sections are found in the documentation. --> <l:context name="xref-number-and-title"> - <l:template name="chapter" text="Chapter %n, %t, in the documentation"/> - <l:template name="sect1" text="Section %n, “%t”, in the documentation"/> - <l:template name="sect2" text="Section %n, “%t”, in the documentation"/> - <l:template name="sect3" text="Section %n, “%t”, in the documentation"/> - <l:template name="sect4" text="Section %n, “%t”, in the documentation"/> - <l:template name="sect5" text="Section %n, “%t”, in the documentation"/> + <l:template name="chapter" text="Chapter %n, &quot;%t&quot;, in the documentation"/> + <l:template name="sect1" text="Section %n, &quot;%t&quot;, in the documentation"/> + <l:template name="sect2" text="Section %n, &quot;%t&quot;, in the documentation"/> + <l:template name="sect3" text="Section %n, &quot;%t&quot;, in the documentation"/> + <l:template name="sect4" text="Section %n, &quot;%t&quot;, in the documentation"/> + <l:template name="sect5" text="Section %n, &quot;%t&quot;, in the documentation"/> </l:context> </l:l10n> </l:i18n>

view thread (70+ messages)  latest in thread

Message-ID: <Zw6eQxtpXIccYpOQ@momjian.us>
Permalink:  ../Zw6eQxtpXIccYpOQ@momjian.us/
Also on:    postgresql.org/message-id/Zw6eQxtpXIccYpOQ@momjian.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, nagata@sraoss.co.jp, ishii@postgresql.org, tgl@sss.pgh.pa.us, daniel@yesql.se
  Subject: Re: Doc: typo in config.sgml
  In-Reply-To: <Zw6eQxtpXIccYpOQ@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox