From: Michael Paquier <michael@paquier.xyz>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Date: Tue, 12 Nov 2024 17:30:30 +0900
Message-ID: <ZzMSJkiNZhimjXWx@paquier.xyz> (raw)
In-Reply-To: <ZywSnWzXskAxSDew@paquier.xyz>
References: <3395418.1618352794@sss.pgh.pa.us>
<3133933.1730855116@sss.pgh.pa.us>
<ZysEEDZqsnP7GTKA@paquier.xyz>
<5829980.DvuYhMxLoT@aivenlaptop>
<ZywSnWzXskAxSDew@paquier.xyz>
On Thu, Nov 07, 2024 at 10:06:37AM +0900, Michael Paquier wrote:
> Good point. Checking all these contrib updates one-by-one is an ant's
> work, but I'll see if I can get at least some of them done on HEAD.
I've begun looking at that a bit, and there are a couple of things
that we could do better with xml2 in 0005 at least in the context of
this patch: xpath_nodeset() and xpath_list() don't have any test
coverage. That's not an issue directly related to this patch, but
perhaps we should add something for the functions that we are
manipulating after this upgrade path at least? That's one way to
automatically make sure that these changes work the same way as the
original.
The same argument comes up with lo_oid() in 0006.
0004 for pg_freespace is fine regarding that for example as we have
calls of pg_freespace(regclass) in its sql/. I've applied it to begin
with something.
Tomas Vondra has posted a patch for a bug fix with pageinspect, so
this would create some conflicts noise for him if 0003 was applied
today, so let's wait a bit:
https://www.postgresql.org/message-id/3385a58f-5484-49d0-b790-9a198a0bf236@vondra.me
0001 and 0002 are much larger than the 4 others, and I'm lacking the
steam to check them in more details today.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, ronan.dunklau@aiven.io, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com
Subject: Re: Converting contrib SQL functions to new style
In-Reply-To: <ZzMSJkiNZhimjXWx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox