From: Jonathan S. Katz <jkatz@postgresql.org>
To: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: language cleanups in code and docs
Date: Wed, 17 Jun 2020 09:36:58 -0400
Message-ID: <a226402a-e3db-43aa-0f76-97e467440ebc@postgresql.org> (raw)
In-Reply-To: <ca7f852cf4c27eaf26da7a76b5d427e4d333a7c4.camel@cybertec.at>
References: <20200615182235.x7lch5n6kcjq4aue@alap3.anarazel.de>
<4601de0f-fc81-de87-7173-75fee5497f85@2ndQuadrant.com>
<1406831.1592351744@sss.pgh.pa.us>
<ca7f852cf4c27eaf26da7a76b5d427e4d333a7c4.camel@cybertec.at>
On 6/17/20 6:06 AM, Laurenz Albe wrote:
> On Tue, 2020-06-16 at 19:55 -0400, Tom Lane wrote:
>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>> On 6/15/20 2:22 PM, Andres Freund wrote:
>>>> 2) 'master' as a reference to the branch. Personally I be in favor of
>>>> changing the branch name, but it seems like it'd be better done as a
>>>> somewhat separate discussion to me, as it affects development
>>>> practices to some degree.
>>> I'm OK with this, but I would need plenty of notice to get the buildfarm
>>> adjusted.
>>
>> "master" is the default branch name established by git, is it not? Not
>> something we picked. I don't feel like we need to be out front of the
>> rest of the world in changing that. It'd be a cheaper change than some of
>> the other proposals in this thread, no doubt, but it would still create
>> confusion for new hackers who are used to the standard git convention.
>
> I have the feeling that all this is going somewhat too far.
First, I +1 the changes Andres proposed overall. In addition to it being
the right thing to do, it brings inline a lot of the terminology we have
been using to describe concepts in PostgreSQL for years (e.g.
primary/replica).
For the name of the git branch, I +1 following the convention of the git
upstream, and make changes based on that. Understandably, it could break
things for a bit, but that will occur for a lot of other projects as
well and everyone will adopt. We have the benefit that we're just
beginning our new development cycle too, so this is a good time to
introduce breaking change ;)
Jonathan
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, laurenz.albe@cybertec.at, tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, andres@anarazel.de
Subject: Re: language cleanups in code and docs
In-Reply-To: <a226402a-e3db-43aa-0f76-97e467440ebc@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox