pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: torikoshia <torikoshia@oss.nttdata.com>
To: htamfids@gmail.com
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Cc: peter@eisentraut.org
Subject: Re: Make --help output fit within 80 columns per line
Date: Mon, 25 Sep 2023 19:13:35 +0900
Message-ID: <a3a2b4158ab15561f8e82486d5fa1eed@oss.nttdata.com> (raw)
In-Reply-To: <eba6645a0e228958d8541f213d66da0f@oss.nttdata.com>
References: <50ca8ff35a8dd8f9ec89963b503571a7@oss.nttdata.com>
	<3965013067e7b6195132da6c0b80a609@oss.nttdata.com>
	<70043684388c1a8d181cf8f3308ad3ec@oss.nttdata.com>
	<c20d4fa43995b3bfbb2c2d06b7ed8731@oss.nttdata.com>
	<7ab6295d479544ae9acb926dc3e556cf@oss.nttdata.com>
	<c42695b0-1471-7d7a-1e60-04541673d507@eisentraut.org>
	<eba6645a0e228958d8541f213d66da0f@oss.nttdata.com>

On 2023-09-25 15:27, torikoshia wrote:
> On Tue, Sep 19, 2023 at 3:23 AM Greg Sabino Mullane 
> <htamfids@gmail.com> wrote:
> Thanks for your investigation!
> 
>> On Fri, Sep 15, 2023 at 11:11 AM torikoshia 
>> <torikoshia@oss.nttdata.com> wrote:
>>> I do not intend to adhere to this rule(my terminals are usually 
>>> bigger
>>> than 80 chars per line), but wouldn't it be a not bad direction to 
>>> use
>>> 80 characters for all commands?
>> 
>> Well, that's the question du jour, isn't it? The 80 character limit is 
>> based on punch cards, and really has no place in modern systems. While 
>> gnu systems are stuck in the past, many other ones have moved on to 
>> more sensible defaults:
>> 
>> $ wget --help | wc -L
>> 110
>> 
>> $ gcloud --help | wc -L
>> 122
>> 
>> $ yum --help | wc -L
>> 122
>> 
>> git is an interesting one, as they force things through a pager for 
>> their help, but if you look at their raw help text files, they have 
>> plenty of times they go past 80 when needed:
>> 
>> $ wc -L git/Documentation/git-*.txt | sort -g | tail -20
>>     109 git-filter-branch.txt
>>     109 git-rebase.txt
>>     116 git-diff-index.txt
>>     116 git-http-fetch.txt
>>     117 git-restore.txt
>>     122 git-checkout.txt
>>     122 git-ls-tree.txt
>>     129 git-init-db.txt
>>     131 git-push.txt
>>     132 git-update-ref.txt
>>     142 git-maintenance.txt
>>     144 git-interpret-trailers.txt
>>     146 git-cat-file.txt
>>     148 git-repack.txt
>>     161 git-config.txt
>>     162 git-notes.txt
>>     205 git-stash.txt
>>     251 git-submodule.txt
>> 
>> So in summary, I think 80 is a decent soft limit, but let's not stress 
>> out about some lines going over that, and make a hard limit of perhaps 
>> 120.
> 
> +1. It may be a good compromise.
> For enforcing the hard limit, is it better to add a regression test
> like patch 0001?

Ugh, regression tests failed and it appears to be due to reasons related 
to meson.
I'm going to investigate it.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation





view thread (15+ messages)  latest in thread

Message-ID: <a3a2b4158ab15561f8e82486d5fa1eed@oss.nttdata.com>
Permalink:  ../a3a2b4158ab15561f8e82486d5fa1eed@oss.nttdata.com/
Also on:    postgresql.org/message-id/a3a2b4158ab15561f8e82486d5fa1eed@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: torikoshia@oss.nttdata.com, htamfids@gmail.com, ikedamsh@oss.nttdata.com, peter@eisentraut.org
  Subject: Re: Make --help output fit within 80 columns per line
  In-Reply-To: <a3a2b4158ab15561f8e82486d5fa1eed@oss.nttdata.com>
  References: <50ca8ff35a8dd8f9ec89963b503571a7@oss.nttdata.com> <3965013067e7b6195132da6c0b80a609@oss.nttdata.com> <70043684388c1a8d181cf8f3308ad3ec@oss.nttdata.com> <c20d4fa43995b3bfbb2c2d06b7ed8731@oss.nttdata.com> <7ab6295d479544ae9acb926dc3e556cf@oss.nttdata.com> <c42695b0-1471-7d7a-1e60-04541673d507@eisentraut.org> <eba6645a0e228958d8541f213d66da0f@oss.nttdata.com> <a3a2b4158ab15561f8e82486d5fa1eed@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox