pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: WIN32 pg_import_system_collations
Date: Thu, 1 Dec 2022 08:46:41 +0100
Message-ID: <a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com> (raw)
In-Reply-To: <CAC+AXB3Wx3CH-1OBEg_1uWcAOzYQ-S+B3_c0emhmgejgen7iNw@mail.gmail.com>
References: <0050ec23-34d9-2765-9015-98c04f0e18ac@postgrespro.ru>
	<639e0abd-ea82-b751-bfba-5166a7a1b304@enterprisedb.com>
	<CAC+AXB0kd+YgF408sy5c2Bsa3PQdiSS6YJZLq6TMx33_WTJ-rA@mail.gmail.com>
	<20220322010057.w7mzoahyi3jy5dyf@alap3.anarazel.de>
	<CAC+AXB1v_H68VQoXK=Pdnc7VwUC-9ifdQEtvyx_qEkMiBGJKbw@mail.gmail.com>
	<CAC+AXB1ha0tnWcqMdjaBq_Lkw346E+h_5UqeYK5NZ29WR8a-bQ@mail.gmail.com>
	<f0ca9ad8-67f9-6d18-ec15-9525f864fa12@enterprisedb.com>
	<CAC+AXB078_wJumwG9nOP--m3cTWKhAUeC22S73rUMVhXknstUg@mail.gmail.com>
	<9f1c24f0-9340-8044-94e7-5f5389a53d08@enterprisedb.com>
	<CAC+AXB2VTU3Udv0nPMB3xO30rnpxcEsFuog7q30S_VmErS4b8g@mail.gmail.com>
	<CAC+AXB3Wx3CH-1OBEg_1uWcAOzYQ-S+B3_c0emhmgejgen7iNw@mail.gmail.com>

On 10.11.22 11:08, Juan José Santamaría Flecha wrote:
>         This looks pretty good to me.  The refactoring of the
>         non-Windows parts
>         makes sense.  The Windows parts look reasonable on manual
>         inspection,
>         but again, I don't have access to Windows here, so someone else
>         should
>         also look it over.
> 
>     I was going to say that at least it is getting tested on the CI, but
>     I have found out that meson changes version(). That is fixed in this
>     version.
> 
> 
> Now is currently failing due to [1], so maybe we can leave this patch on 
> hold until that's addressed.
> 
> [1] 
> https://www.postgresql.org/message-id/CAC%2BAXB1wJEqfKCuVcNpoH%3Dgxd61N%3D7c2fR3Ew6YRPpSfEUA%3DyQ%40... <https://www.postgresql.org/message-id/CAC%2BAXB1wJEqfKCuVcNpoH%3Dgxd61N%3D7c2fR3Ew6YRPpSfEUA%3DyQ%40...;

What is the status of this now?  I think the other issue has been addressed?






view thread (32+ messages)  latest in thread

Message-ID: <a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com>
Permalink:  ../a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com/
Also on:    postgresql.org/message-id/a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, juanjo.santamaria@gmail.com, d.koval@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: WIN32 pg_import_system_collations
  In-Reply-To: <a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox