agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Date: Mon, 28 Apr 2025 09:41:26 -0500
Message-ID: <aA-TlhU2ZoBBAqc-@nathan> (raw)
In-Reply-To: <713236.1745846094@sss.pgh.pa.us>
References: <Z3xV_b3wp-XQR3Rm@nathan>
<7B8590B5-3A23-4CF6-B21D-4AA8C0177C2C@anarazel.de>
<1353350.1736202977@sss.pgh.pa.us>
<Z3xlNmC3qtwf1lz1@nathan>
<1359669.1736206603@sss.pgh.pa.us>
<Z3yVFfKG_RAh8FgP@nathan>
<1386858.1736220547@sss.pgh.pa.us>
<Z31jI10tLLd6thfu@nathan>
<de722583-4ba4-4063-bc41-e20684978116@eisentraut.org>
<713236.1745846094@sss.pgh.pa.us>
On Mon, Apr 28, 2025 at 09:14:54AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> This initdb output seems, well, kinda fake, which it is by its own
>> admission.
>
> Agreed.
>
>> Could we do this less fake maybe like this:
>> selecting default "max_connections", "autovacuum_worker_slots" ... 100, 16
>> with the actual wait at the "..."?
>
> Perhaps that would be all right ...
>
>> (It doesn't seem impossible that someone will want to add more default
>> selecting for various worker or process slots, and this would allow adding
>> these easily, versus adding more "fake" output lines.)
>
> ... but I can't see this approach scaling to three or four or five
> outputs. The line would get unreasonably long.
>
> My own proposal given the way it works now is to just print
> max_connections and not mention autovacuum_worker_slots at all.
> Our choice for max_connections is worth reporting, but I don't
> feel that everything derived from it needs to be reported.
I'm fine with either of these ideas. If I had to choose one, I'd just
remove the autovacuum_worker_slots report for the reasons Tom noted.
However, weren't we considering reverting some of this stuff [0]? I see
that sawshark is now choosing max_connections = 40 and
autovacuum_worker_slots = 6, and since there are no other apparent related
buildfarm failures, I'm assuming that nobody else is testing the 60
semaphores case anymore.
[0] https://postgr.es/m/618497.1742347456%40sss.pgh.pa.us
--
nathan
view thread (71+ messages) latest in thread
Message-ID: <aA-TlhU2ZoBBAqc-@nathan>
Permalink: ../aA-TlhU2ZoBBAqc-@nathan/
Also on: postgresql.org/message-id/aA-TlhU2ZoBBAqc-@nathan
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, andres@anarazel.de, simseih@amazon.com, pryzby@telsasoft.com
Subject: Re: allow changing autovacuum_max_workers without restarting
In-Reply-To: <aA-TlhU2ZoBBAqc-@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox