From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nisha Moond <nisha.moond412@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Date: Wed, 7 May 2025 14:55:49 -0500
Message-ID: <aBu6xdbOqelnZOCZ@nathan> (raw)
In-Reply-To: <aBqUlxmOf9qvVIhT@paquier.xyz>
References: <aAlfU06XTChyIGBD@nathan>
<aA_zMYasoUwNrDx1@nathan>
<905635.1745876108@sss.pgh.pa.us>
<aA_4S5ZBaI_Qje2s@nathan>
<910625.1745878759@sss.pgh.pa.us>
<aBEO7vzq1jw9L_Pv@nathan>
<1055453.1745949714@sss.pgh.pa.us>
<aBF1ii89jdzQsVvB@paquier.xyz>
<aBo7zUx3XpbA2Jo1@nathan>
<aBqUlxmOf9qvVIhT@paquier.xyz>
On Wed, May 07, 2025 at 08:00:39AM +0900, Michael Paquier wrote:
> On Tue, May 06, 2025 at 11:41:49AM -0500, Nathan Bossart wrote:
>> I brought this up with the RMT, and everyone seemed okay with committing it
>> for v18.
>
> Cool, thanks for the update.
>
>> I can move it back to replorigin_create(). I don't have a strong opinion
>> here.
>
> I think that I would the check there, as that's safer in the long-run
> to enforce the rule to all potential callers of this API. If the
> votes balance in favor of keeping it in the SQL function, that's OK by
> me as well, so feel free to ignore me if you feel strongly about it
> overall.
Committed with that change. That takes care of a good chunk of these TOAST
snapshot problems. I think there are about 4 others left, unless something
has changed since I last checked. I hope to look into those again soon.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, nisha.moond412@gmail.com, euler@eulerto.com, amit.kapila16@gmail.com, exclusion@gmail.com, jkatz@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
In-Reply-To: <aBu6xdbOqelnZOCZ@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox