From: Nathan Bossart <nathandbossart@gmail.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Date: Thu, 12 Jun 2025 15:57:01 -0500
Message-ID: <aEs_HXlnoyrGzuo-@nathan> (raw)
In-Reply-To: <CADkLM=fguOpQui=_OBUObuR-Gt36pBdUYzQXQ4n9TdkxXL_BAQ@mail.gmail.com>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
<aEMLzPQtjRbj2R7X@nathan>
<CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
<aErpuM6RXSlK1FBW@nathan>
<7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
<CA+TgmoZxMckFy3-hr7wsuz2UwnwrG=vOCdcTxVUVgXdnDtj94w@mail.gmail.com>
<CADkLM=f2GB1fNTRWaUWptu1rJKMjrR_DJ_6J9hg34RuEm6sQ8g@mail.gmail.com>
<aEs29UQXDHxxoPtd@nathan>
<CADkLM=fguOpQui=_OBUObuR-Gt36pBdUYzQXQ4n9TdkxXL_BAQ@mail.gmail.com>
On Thu, Jun 12, 2025 at 04:39:00PM -0400, Corey Huinker wrote:
> On Thu, Jun 12, 2025 at 4:22 PM Nathan Bossart <nathandbossart@gmail.com>
> wrote:
>> I do think this is useful functionality, I only suggested removing it
>> because AFAICT it is redundant, i.e., you can accomplish the same thing
>> with --with-statistics --no-schema --no-data. It seems like we're trying
>> to avoid having multiple ways to do the same thing.
>
> By that same argument, we should remove --schema-only and --data-only as
> well. I think we shouldn't because those two options have proved very
> convenient for users and they convey clear intent to the person reading the
> script, and I believe that --statistics-only will prove the same over time.
Those predate v18, so while might be able to mark them deprecated, I doubt
we'd remove them anytime soon.
FWIW I don't have a tremendously strong opinion about --statistics-only.
I'd probably vote to remove it because 1) it's redundant, 2) once you add
an option, it's hard to remove it, and 3) pg_dump already has so many
options. But I won't cry too hard if we keep it around.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, corey.huinker@gmail.com, robertmhaas@gmail.com, pgsql@j-davis.com, peter@eisentraut.org
Subject: Re: pg_dump --with-* options
In-Reply-To: <aEs_HXlnoyrGzuo-@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox