pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Greg Sabino Mullane <htamfids@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
Date: Thu, 19 Jun 2025 16:09:21 +0900
Message-ID: <aFO3oaP_ew1qycbv@paquier.xyz> (raw)
In-Reply-To: <CAGECzQSP2=TmJHvnMm0T_88ERgWm9BDz1my0F_EqyX+Oexsg=Q@mail.gmail.com>
References: <ZpnODDZT-aosIUAE@paquier.xyz>
	<ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com>
	<ZqCLRa5OxPqzqWh6@paquier.xyz>
	<3e694442-0df5-4f92-a08f-c5d4c4346b85@eisentraut.org>
	<CAKAnmmK+VU022r5AoHSJhyOfGy8tUgLgYcb6u5nBH-BPnKbKhw@mail.gmail.com>
	<aEuTZb5WS9RIoZnb@paquier.xyz>
	<20476f68-26e4-4a3b-b2e6-1c7554359fe8@eisentraut.org>
	<CAGECzQSPoYu=G9JKVpcBM2m=K8qfu3CyFTiznLLeo+tDbp_QYQ@mail.gmail.com>
	<CAO6_XqqWkqHFObGo7mhUgBztj05wP9OxHmLd2sJccs4H_uPM+g@mail.gmail.com>
	<CAGECzQSP2=TmJHvnMm0T_88ERgWm9BDz1my0F_EqyX+Oexsg=Q@mail.gmail.com>

On Wed, Jun 18, 2025 at 09:15:07AM +0200, Jelte Fennema-Nio wrote:
> On Wed, 18 Jun 2025 at 08:23, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote:
>> Since \bind_named is also new, we can also rename it to make it
>> consistent with close meta-command. So what about renaming \bind_named
>> to \bindprepared and \close to \closeprepared?
> 
> I think I still prefer \bind_named or maybe \bindnamed (depending on
> what our policy for underscores in \ commands is).

Not sure that there is such a policy in place.  I find names with
underscores easier to parse.

> For that command it
> should differentiate from the already existing \bind command, which is
> also for prepared statements, just not for "named" prepared
> statements. While close needs to differentiate from close for portals
> vs close for prepared statements.

Good point.  I would be on board with a \close_prepared then, if
that's the consensus we reach, without touching at \bind_named.  We
still have time to decide on the name until the release, just let's
make sure to not do a rename multiple times.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (44+ messages)  latest in thread

Message-ID: <aFO3oaP_ew1qycbv@paquier.xyz>
Permalink:  ../aFO3oaP_ew1qycbv@paquier.xyz/
Also on:    postgresql.org/message-id/aFO3oaP_ew1qycbv@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, postgres@jeltef.nl, anthonin.bonnefoy@datadoghq.com, peter@eisentraut.org, htamfids@gmail.com, vignesh21@gmail.com
  Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
  In-Reply-To: <aFO3oaP_ew1qycbv@paquier.xyz>
  References: <ZpnODDZT-aosIUAE@paquier.xyz> <ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com> <ZqCLRa5OxPqzqWh6@paquier.xyz> <3e694442-0df5-4f92-a08f-c5d4c4346b85@eisentraut.org> <CAKAnmmK+VU022r5AoHSJhyOfGy8tUgLgYcb6u5nBH-BPnKbKhw@mail.gmail.com> <aEuTZb5WS9RIoZnb@paquier.xyz> <20476f68-26e4-4a3b-b2e6-1c7554359fe8@eisentraut.org> <CAGECzQSPoYu=G9JKVpcBM2m=K8qfu3CyFTiznLLeo+tDbp_QYQ@mail.gmail.com> <CAO6_XqqWkqHFObGo7mhUgBztj05wP9OxHmLd2sJccs4H_uPM+g@mail.gmail.com> <CAGECzQSP2=TmJHvnMm0T_88ERgWm9BDz1my0F_EqyX+Oexsg=Q@mail.gmail.com> <aFO3oaP_ew1qycbv@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox