pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
Date: Fri, 19 Jul 2024 15:28:44 +0200
Message-ID: <ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com> (raw)
In-Reply-To: <ZpnODDZT-aosIUAE@paquier.xyz>
References: <CAGECzQQL6=8JZ_UqLbt=Ma-FKtRQWX6HPjJh8ueG5-YMjSU0OQ@mail.gmail.com>
	<CAO6_XqqGScQuGbkzoH90Rb-eD0hJtaYGMCs4akgTEocGanw0sQ@mail.gmail.com>
	<CAGECzQR1+udGKz+FbHiCQ7CWDiF1fCGi2xYuvQUODdMAfJbaLA@mail.gmail.com>
	<ZaeBtEaIMzlGvBJ9@paquier.xyz>
	<CAO6_XqoxjRngBxnQdT0HL6HJrva5jpKeRvs3H6T8XGoTh2PDVw@mail.gmail.com>
	<Zah-54B6fXv9JGXs@paquier.xyz>
	<CAO6_Xqr7kUtEv8UrWtYx33tksAwMehHiwaBJxyV9XmL0RVpZiA@mail.gmail.com>
	<ZaoGnyzK60CqwE4_@paquier.xyz>
	<CALDaNm2i=xY85Jhg5Pr+7-yTt_Ar3tQebrDGRvxB4j2VqWEOZw@mail.gmail.com>
	<6cece376-07c6-4075-87b6-937156814202@enterprisedb.com>
	<ZpnODDZT-aosIUAE@paquier.xyz>

On 7/19/24 04:23, Michael Paquier wrote:
> On Fri, Jul 19, 2024 at 12:17:44AM +0200, Tomas Vondra wrote:
>> shall we do something about this patch? It seems to be in a pretty good
>> shape (pretty much RFC, based on quick review), the cfbot is still
>> happy, and there seems to be agreement this is a nice feature.
>>
>> Michael, I see you've reviewed the patch in January. Do you agree / plan
>> to get it committed, or should I take a look?
> 
> This feel off my radar a bit, thanks for the reminder :)
> 
> I have a local branch dating back from January where this patch is
> sitting, with something like 50% of the code reviewed.  I'd still need
> to look at the test coverage, but I did like the proposed patch a lot
> based on my notes.
> 
> I may be able to come back to that if not next week, then the week
> after that.  If you want to handle it yourself before that, that's
> fine by me.

OK, if you're already half-way through the review, I'll leave it up to
you. I don't think we need to rush, and I'd have to learn about all the
psql stuff first anyway.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (44+ messages)  latest in thread

Message-ID: <ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com>
Permalink:  ../ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com/
Also on:    postgresql.org/message-id/ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, michael@paquier.xyz, vignesh21@gmail.com, anthonin.bonnefoy@datadoghq.com, postgres@jeltef.nl
  Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
  In-Reply-To: <ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com>
  References: <CAGECzQQL6=8JZ_UqLbt=Ma-FKtRQWX6HPjJh8ueG5-YMjSU0OQ@mail.gmail.com> <CAO6_XqqGScQuGbkzoH90Rb-eD0hJtaYGMCs4akgTEocGanw0sQ@mail.gmail.com> <CAGECzQR1+udGKz+FbHiCQ7CWDiF1fCGi2xYuvQUODdMAfJbaLA@mail.gmail.com> <ZaeBtEaIMzlGvBJ9@paquier.xyz> <CAO6_XqoxjRngBxnQdT0HL6HJrva5jpKeRvs3H6T8XGoTh2PDVw@mail.gmail.com> <Zah-54B6fXv9JGXs@paquier.xyz> <CAO6_Xqr7kUtEv8UrWtYx33tksAwMehHiwaBJxyV9XmL0RVpZiA@mail.gmail.com> <ZaoGnyzK60CqwE4_@paquier.xyz> <CALDaNm2i=xY85Jhg5Pr+7-yTt_Ar3tQebrDGRvxB4j2VqWEOZw@mail.gmail.com> <6cece376-07c6-4075-87b6-937156814202@enterprisedb.com> <ZpnODDZT-aosIUAE@paquier.xyz> <ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox