From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fix ancient typo in transformRelOptions()
Date: Tue, 5 Aug 2025 21:20:09 -0500
Message-ID: <aJK72dWoPnTZrB63@nathan> (raw)
In-Reply-To: <1290107.1754431854@sss.pgh.pa.us>
References: <202508052156.d7n5jjro3jne@alvherre.pgsql>
<1290107.1754431854@sss.pgh.pa.us>
On Tue, Aug 05, 2025 at 06:10:54PM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
>> On 2025-Aug-05, Nathan Bossart wrote:
>>> I noticed that this function has a "namspace" parameter. The attached
>>> patch adds the missing 'e'.
>
>> I have vague recollections of it being this way because of "namespace"
>> being a C++ keyword. (commit is 3a5b77371522, but I don't have energy
>> to look for the discussion right now.)
>
> Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
> I didn't locate the discussion of "namspace" either, but I did
> notice that de160e2c0 used "nameSpace" for the same purpose.
> Maybe we should standardize on that? It looks less like a typo
> than "namspace", for sure.
That explains it. I didn't find any past discussions about this particular
name, but commit de160e2 was being developed concurrently. I'll use
nameSpace instead.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, alvherre@kurilemu.de
Subject: Re: fix ancient typo in transformRelOptions()
In-Reply-To: <aJK72dWoPnTZrB63@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox