From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@postgresql.org, david@justatheory.com, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: Fri, 17 Oct 2025 15:01:53 -0500
Message-ID: <aPKgsRX0WKmuaQmD@nathan> (raw)
In-Reply-To: <1730702.1760730789@sss.pgh.pa.us>
References: <aPJ03E2itovDBcKX@nathan>
<1713509.1760721320@sss.pgh.pa.us>
<aPKFmL8VjOKNVLcw@nathan>
<1723302.1760726712@sss.pgh.pa.us>
<aPKUzk2xFhZBbWmz@nathan>
<CAH2-WznQY7UaGGdAgg0crnJ8j1R3MW8rMqEynDBMTio+7WAYXA@mail.gmail.com>
<aPKY4fJVgKrX76p-@nathan>
<CAH2-Wzne4pkk+jEg0vQC8qSdqHHqt64HHRgkzud3hvkGWKNnjA@mail.gmail.com>
<aPKbY4vzdNWoKloK@nathan>
<1730702.1760730789@sss.pgh.pa.us>
On Fri, Oct 17, 2025 at 03:53:09PM -0400, Tom Lane wrote:
> I don't see a race condition here. What would happen is we make
> some commit, realizing either at the time or later that it involves
> an ABI break. We verify via some later buildfarm run that the
> break is as-expected (ie the commit doesn't introduce any unwanted
> changes, nor is there anything hanging around from some older commit).
> Then we push an update to the .abi_reference file that points at
> that commit, and the buildfarm starts comparing ABI of branch tip
> to that commit instead of whatever was the reference commit before.
> No later activity breaks the conclusion that we were okay with the ABI
> that that commit creates, nor can any earlier commit cause problems
> so long as we did our due diligence in checking the ABI-break reports.
>
> In theory, if two ABI-breaking commits go in so close together that
> there was no ABI-checking buildfarm run in between, we might have
> difficulty untangling their effects. That doesn't seem very likely
> in practice, and even if it happens, so what? Either we're good with
> the ABI-break report when we see it, or we're not.
Ah, I was thinking of a more proactive approach (e.g., I commit something
that I know introduces ABI breakage, and then I immediately update the ABI
reference file in the next commit). I like the idea of simply reacting to
the reports and using that as an opportunity to verify it's what we expect.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, pg@bowt.ie, andrew@dunslane.net
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
In-Reply-To: <aPKgsRX0WKmuaQmD@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox