agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Nathan Bossart <nathandbossart@gmail.com>
To: David E. Wheeler <david@justatheory.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Cc: Mankirat Singh <mankiratsingh1315@gmail.com>
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: Fri, 17 Oct 2025 15:11:35 -0500
Message-ID: <aPKi9w8zP14tZonW@nathan> (raw)
In-Reply-To: <78B81B37-9F27-4085-92DA-6B50DFC24361@justatheory.com>
References: <aPJ03E2itovDBcKX@nathan>
	<1713509.1760721320@sss.pgh.pa.us>
	<aPKFmL8VjOKNVLcw@nathan>
	<1723302.1760726712@sss.pgh.pa.us>
	<aPKUzk2xFhZBbWmz@nathan>
	<78B81B37-9F27-4085-92DA-6B50DFC24361@justatheory.com>

On Fri, Oct 17, 2025 at 03:52:18PM -0400, David E. Wheeler wrote:
> Adding Mankirat, who developed the ABI checker for his GSoC project.

Thanks for chiming in.

> Is the idea that the ABI checker just has to scan the first non-comment
> line that starts with a commit identifier (SHA or tag)?

Yes.

> Seems totally do-able, though I don’t know what that `(Apple Git-154)`
> bit is doing at the end.

I think that's just telling you what version of git I used to create the
patch file.

> I presume it would list the history of changes in reverse chronological
> order, yes?

Yes, although we could change it to whatever we want.

> If there is a tag _AFTER_ the listed SHA, should we prefer that tag as
> the baseline?

I don't see any need to consider tags at all.  We'd initialize this file
when creating the new STABLE branch with a baseline commit near a release
candidate or the .0, and then we'd just add future baselines as needed.
The ABI checks would always use the latest baseline, even if it points to
something before the latest release tag.  (At least, this is how I'm
thinking about it.)

-- 
nathan

view thread (70+ messages)  latest in thread

Message-ID: <aPKi9w8zP14tZonW@nathan>
Permalink:  ../aPKi9w8zP14tZonW@nathan/
Also on:    postgresql.org/message-id/aPKi9w8zP14tZonW@nathan

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, david@justatheory.com, tgl@sss.pgh.pa.us, andrew@dunslane.net, mankiratsingh1315@gmail.com
  Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
  In-Reply-To: <aPKi9w8zP14tZonW@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox