From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Extended Statistics set/restore/clear functions.
Date: Mon, 26 Jan 2026 16:42:38 +0900
Message-ID: <aXca7jnwtzFSYr4s@paquier.xyz> (raw)
In-Reply-To: <CADkLM=c7DY3Jv6ef0n_MGUJ1FyTMUoT697LbkST05nraVGNHYg@mail.gmail.com>
References: <aW3UcP6rGXMLjkwm@paquier.xyz>
<CADkLM=dJ4bQ3e4Cc+vaVFmnrL37Y5hPJ1u0AYXE6fSkh_=+sTg@mail.gmail.com>
<aXAXMwHYF1qyUaP5@paquier.xyz>
<CADkLM=c3s-BtSebTHggY__DOYFMCdknaLuJHwG0o817o0Q9tNA@mail.gmail.com>
<aXHGoMAnzV5njUEo@paquier.xyz>
<CADkLM=c3JivzHNXLt-X_JicYknRYwLTiOCHOPiKagm2_vdrFUg@mail.gmail.com>
<aXVw4LGO4fWunn4n@paquier.xyz>
<CADkLM=f4+3_HrXSAaEic5VGGd-fOjS4jGnr1WGJYrL7vf3ZJnw@mail.gmail.com>
<aXWBhkru03FnrfIW@paquier.xyz>
<CADkLM=c7DY3Jv6ef0n_MGUJ1FyTMUoT697LbkST05nraVGNHYg@mail.gmail.com>
On Sun, Jan 25, 2026 at 05:20:13AM -0500, Corey Huinker wrote:
> Ok, here's my attempt at splitting things out:
>
> 0001 - Add attribute stats test for multiranges
This was indeed independent of the rest, qualifying as a test defect
on v18, so applied first.
> 0002 - Basic restore functionality ndistinct
This has been combined with portions of 0007 to make sure that some
docs are there, with irrelevant portions related to other stats kinds
removed.
> 0003 - add dependencies
This one is simple. It still needs a couple of adjustments (elog
messages on one line, one more test).
> 0004 - add mcv
> 0005 - add expressions
These would be next in line.
> 0006 - Add in the before/after diff test on a stats object (in theory this
> could be added after 0002)
I think that this would mean 0005 now.
> 0007 - add SGML
Partially done.
> 0008 - restore MAINTAIN test (in theory this could be merged into 0002)
I was hesitating to do exactly that, but just split things at the end.
This patch was actually incorrect, with regress_test_extstat_clear
as role name getting partially used. The output was wrong.
Another side note: I am not sure how the CI or the buldfarm did not
notice that, but I've found a bug in the tuple initialization logic
while reviewing more the code, fixed in 114e84c532d1. Perhaps my
build environment was more efficient in detecting that.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, corey.huinker@gmail.com, li.evan.chao@gmail.com, tndrwang@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Extended Statistics set/restore/clear functions.
In-Reply-To: <aXca7jnwtzFSYr4s@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox