From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Miscellaneous message fixes
Date: Tue, 10 Feb 2026 16:14:17 +0900
Message-ID: <aYrayZUfXKup-eEb@paquier.xyz> (raw)
In-Reply-To: <20260210.143752.1113524465620875233.horikyota.ntt@gmail.com>
References: <20260210.143752.1113524465620875233.horikyota.ntt@gmail.com>
On Tue, Feb 10, 2026 at 02:37:52PM +0900, Kyotaro Horiguchi wrote:
> 0006:
> In extended_stats_funcs.c:
>> errmsg("could not find extended statistics object \"%s\".\"%s\"",
>> quote_identifier(nspname),
>> quote_identifier(stxname)));
>
> Since quote_identifier() already adds quoting when needed, adding
> "%s"."%s" in the format string results in double quoting. It would be
> better to use %s.%s instead. I think quoting should be applied only
> when necessary here. I'm not sure we should use
> quote_qualified_identifier() instead.. (It's not used in the attached
> patch).
>
> There's a similar inconsistency.
>
>> errmsg("could not clear extended statistics object \"%s\".\"%s\": incorrect relation \"%s\".\"%s\" specified",
>> get_namespace_name(nspoid), stxname,
>> relnspname, relname));
>
> In this part, the names are not passed through quote_identifier(). It
> would be better to unify this as well.
0006 relates to some of my recent business, so I'll go look and
address this part. Thanks for the report.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aYrayZUfXKup-eEb@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Miscellaneous message fixes
In-Reply-To: <aYrayZUfXKup-eEb@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox