pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgbackrest.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improve verification of recovery_target_timeline GUC.
Date: Fri, 20 Feb 2026 12:38:35 +0900
Message-ID: <aZfXO97jSQaTTlfD@paquier.xyz> (raw )
In-Reply-To: <7c1eb8fe-7a19-43d0-84cb-9840d8bcdd14@pgbackrest.org >
References: <e5d472c7-e9be-4710-8dc4-ebe721b62cea@pgbackrest.org >
<Z5M2tgQUMgCkyrKJ@paquier.xyz >
<a17d1bf9-8123-4b86-9c84-5b7526cd70fd@pgbackrest.org >
<Z67z1UndsbKGOuLt@paquier.xyz >
<ac0d1e55-75f6-40d1-882d-05274811f294@pgbackrest.org >
<aArTehpV_Mr8Lqf_@paquier.xyz >
<08cf439a-4566-4698-b60f-d8e9ed348456@pgbackrest.org >
<aGXp4j8twyuruf1k@paquier.xyz >
<7c1eb8fe-7a19-43d0-84cb-9840d8bcdd14@pgbackrest.org >
On Fri, Feb 20, 2026 at 03:25:30AM +0000, David Steele wrote:
> I noticed that when you replaced UINT_MAX with PG_UINT32_MAX you missed one
> instance. Fixed in the attached.
Added pgsql-hackers in CC for awareness, with your proposed patch
attached, David.
It looks so. Will fix, thanks!
--
Michael
Attachments:
uint32.patch (text/plain, 581B) download
diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c
index c0c2744d45b..fc794693442 100644
--- a/src/backend/access/transam/xlogrecovery.c
+++ b/src/backend/access/transam/xlogrecovery.c
@@ -5070,7 +5070,7 @@ check_recovery_target_timeline(char **newval, void **extra, GucSource source)
if (timeline < 1 || timeline > PG_UINT32_MAX)
{
GUC_check_errdetail("\"%s\" must be between %u and %u.",
- "recovery_target_timeline", 1, UINT_MAX);
+ "recovery_target_timeline", 1, PG_UINT32_MAX);
return false;
}
}
download
view thread (10+ messages)
Message-ID: <aZfXO97jSQaTTlfD@paquier.xyz>
Permalink: ../aZfXO97jSQaTTlfD@paquier.xyz/
Also on: postgresql.org/message-id/aZfXO97jSQaTTlfD@paquier.xyz
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, david@pgbackrest.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Improve verification of recovery_target_timeline GUC.
In-Reply-To: <aZfXO97jSQaTTlfD@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox