public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Chao Li <[email protected]>
Cc: [email protected]
Cc: Jeff Davis <[email protected]>
Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
Date: Fri, 27 Feb 2026 06:45:29 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <aaEhpwrj1FY/8/[email protected]>
	<[email protected]>

Hi,

On Fri, Feb 27, 2026 at 02:04:30PM +0800, Chao Li wrote:
> 
> 
> What I'm interested in is the broader policy: when reviewing patches,
> if we encounter a foo() declaration, should we consistently request a change to foo(void)?
> If yes, the standard should be documented somewhere.

I think that they should be consistently fixed for the reasons mentioned in 
[1], and that the best way to achieve this goal would be to enable -Wstrict-prototypes
by default ([2]).

[1]: https://postgr.es/m/aTBObQPg%2Bps5I7vl%40ip-10-97-1-34.eu-west-3.compute.internal
[2]: https://postgr.es/m/aTJ9T8HyJN3D024w%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox