From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
Date: Fri, 14 Dec 2018 08:55:52 +0100
Message-ID: <aad2ec49-5142-7356-ffb2-a9b2649cdd1f@2ndquadrant.com> (raw)
In-Reply-To: <20181214001457.GP3415@tamriel.snowman.net>
References: <CAB7nPqSS7xVKGkQbroiJ_wFgxa9n3COnemGzeXv36-A3XLbAeg@mail.gmail.com>
<CAMsr+YGhS541Zx7kmda5SXLS3NLeY71HksZrbRsRbbS3VaXfkQ@mail.gmail.com>
<20180126022813.GD2416@tamriel.snowman.net>
<9523ad05-525c-598e-ad2d-061b5a94062c@proxel.se>
<20180201062158.GD6398@paquier.xyz>
<60052986-956b-4478-45ed-8bd119e9b9cf@2ndquadrant.com>
<10797471544200851@myt3-964eae3a5b05.qloud-c.yandex.net>
<93a3d2fb-43a0-cf14-e8d0-d2c3195c1e5b@2ndquadrant.com>
<20486991544381729@iva5-d3020dc3459d.qloud-c.yandex.net>
<52aae11b-bfa5-6ccc-3b98-774f4836ab42@2ndquadrant.com>
<20181214001457.GP3415@tamriel.snowman.net>
On 14/12/2018 01:14, Stephen Frost wrote:
>>>> reindex table CONCURRENTLY test;
>>
>> By the way, does this syntax make sense? I haven't seen a discussion on
>> this anywhere in the various threads. I keep thinking that
>>
>> reindex concurrently table test;
>>
>> would make more sense. How about in combination with (verbose)?
>
> I don't think it's a mistake that we have 'create index concurrently'
> and it certainly would seem odd to me for 'create index' and 'reindex
> table' to be different.
>
> Certainly, from my recollection of english, you'd say "I am going to
> reindex the table concurrently", you wouldn't say "I am going to
> reindex concurrently the table."
>
> Based on at least a quick looking around, the actual grammar rule seems
> to match my recollection[1], adverbs should typically go AFTER the
> verb + object, and the adverb shouldn't ever be placed between the verb
> and the object.
So it would be grammatical to say
reindex table test concurrently
or in a pinch
reindex concurrently table test
but I don't see anything grammatical about
reindex table concurrently test
(given that the object is "table test").
Where this gets really messy is stuff like this:
reindex (verbose) database concurrently postgres
Why would "concurrently" not be part of the options next to "verbose"?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, sfrost@snowman.net, sk@zsrv.org, michael.paquier@gmail.com, andreas@proxel.se, craig@2ndquadrant.com, alvherre@alvh.no-ip.org
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
In-Reply-To: <aad2ec49-5142-7356-ffb2-a9b2649cdd1f@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox