pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Erik Wienhold <ewie@ewie.name>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Hannu Krosing <hannuk@google.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there
Date: Fri, 26 Jul 2024 04:11:22 +0200
Message-ID: <ab400585-e89d-4479-a4bf-0a1c122b7bbf@ewie.name> (raw)
In-Reply-To: <1556597.1721939351@sss.pgh.pa.us>
References: <CAKFQuwYcV+AZMbyzHyDdxFhp_GH5Nty_GL1U5JkPYJeya0MLYQ@mail.gmail.com>
	<73jtqglviqor5ozqrthjmau7nj4xi7z4obzaqflf7cvliaf4em@4obr7wqlqkye>
	<CAKFQuwYCqsapMBvQm9hTpD7urTaaOtJbpkpe7GaXr5ksMT58rA@mail.gmail.com>
	<efxy4vnyrwhowyyv7vk6s7ps6bwkyizdmaehs7mppjzapssvxl@n5nuyelnyfcj>
	<CA+TgmoZ4cUNV8BbMz6anMTsbcKkCQSs+V_ZWdCd5=2SB9pe67Q@mail.gmail.com>
	<CAKFQuwZQ2+YAerqxo4zJ0mreowBqe9T0k0KPvAaqwgvFNGOR5A@mail.gmail.com>
	<e905f37d-7535-4df7-b171-ce1e569f4b40@ewie.name>
	<CAKFQuwZkVT0RDoYzt-v=-+330xaEaVo=vqLOqezuLZZ5X5-3oA@mail.gmail.com>
	<1cd8a224-4038-43ba-bb11-a4cd8d015462@ewie.name>
	<1556597.1721939351@sss.pgh.pa.us>

On 2024-07-25 22:29 +0200, Tom Lane wrote:
> Erik Wienhold <ewie@ewie.name> writes:
> > Thanks, I didn't know that guideline.  Both fixed in v6.
> 
> This still isn't following our usual message style IMO.  Here's a
> proposed v7 that outputs
> 
> -ERROR:  type stuff is not a composite type
> +ERROR:  type stuff is the row type of another table
> +DETAIL:  A typed table must use a stand-alone composite type created with CREATE TYPE.
> 
> I did a bit of copy-editing on the docs changes too.  One notable
> point is that I dropped the parenthetical bit about "(name optionally
> schema-qualified)".  That struck me as quite unnecessary, and
> it definitely doesn't read well to have two parenthetical comments
> in a single four-line sentence.

Works for me.  Thanks!

-- 
Erik





view thread (17+ messages)  latest in thread

Message-ID: <ab400585-e89d-4479-a4bf-0a1c122b7bbf@ewie.name>
Permalink:  ../ab400585-e89d-4479-a4bf-0a1c122b7bbf@ewie.name/
Also on:    postgresql.org/message-id/ab400585-e89d-4479-a4bf-0a1c122b7bbf@ewie.name

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ewie@ewie.name, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, robertmhaas@gmail.com, hannuk@google.com, peter@eisentraut.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there
  In-Reply-To: <ab400585-e89d-4479-a4bf-0a1c122b7bbf@ewie.name>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox