public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Michael Banck <[email protected]>
To: Jeff Davis <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Holger Jakobs <[email protected]>
Cc: Jeff Davis <[email protected]>
Subject: Re: Improve error message for ICU libraries if pkg-config is absent
Date: Thu, 15 Aug 2024 15:22:00 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 15.08.24 09:20, Michael Banck wrote:
> On Wed, Aug 14, 2024 at 06:05:19PM -0700, Jeff Davis wrote:
>> That looks good to me. Does anyone have a different opinion? If not,
>> I'll go ahead and commit (but not backport) this change.
> 
> What is the rationale not to backpatch this? The error message changes,
> but we do not translate configure output, so is this a problem/project
> policy to never change configure output in the back-branches?
> 
> If the change is too invasive, would something like the initial patch I
> suggested (i.e., in the absense of pkg-config, add a more targetted
> error message) be acceptable for the back-branches?

But it's not just changing an error message, it's changing the logic 
that leads to the error message.  Have we really thought through all the 
combinations here?  I don't know.  So committing for master and then 
seeing if there is any further feedback seems most prudent.

(I'm not endorsing either patch version here, just commenting on the 
process.)

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Improve error message for ICU libraries if pkg-config is absent
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox