public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jeff Davis <[email protected]>
To: Michael Banck <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Holger Jakobs <[email protected]>
Cc: Jeff Davis <[email protected]>
Subject: Re: Improve error message for ICU libraries if pkg-config is absent
Date: Wed, 14 Aug 2024 18:05:19 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Fri, 2024-08-09 at 11:44 +0200, Michael Banck wrote:
> So maybe the better change is to just remove the explicit error
> message
> again and depend on PKG_CHECK_MODULES erroring out helpfully?  The
> downside would be that the hint about specifying --without-icu to get
> around this would disappear, but I think somebody building from
> source
> can figure that out more easily than the subtle issue that pkg-config
> is
> not installed.

That looks good to me. Does anyone have a different opinion? If not,
I'll go ahead and commit (but not backport) this change.

Regards,
	Jeff Davis

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Improve error message for ICU libraries if pkg-config is absent
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox