public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: Defend against -ffast-math in meson builds
Date: Wed, 11 Mar 2026 15:51:46 +0000
Message-ID: <abGPko4lPv/[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe>
	<[email protected]>
	<[email protected]>

Hi,

On Wed, Mar 11, 2026 at 11:19:45AM -0400, Tom Lane wrote:
> Peter Eisentraut <[email protected]> writes:
> > The existing check in configure is because certain Linux distributions 
> > used to compile everything with -ffast-math to be "faster", and that 
> > kept breaking PostgreSQL and so we wanted to stop them very early. 
> > These are gone, and the defenses in the code like date.c should be 
> > sufficient for any new attempts.  I think we could remove the check in 
> > configure.
> 
> The defenses in those modules are probably obsolete too: aren't they about
> ensuring exact results with floating-point timestamps?  My gut reaction to
> this was maybe we could remove *all* of that, so now I'm curious what
> problem Bertrand ran into.

I got some regression tests failing: [1].

[1]: https://postgr.es/m/abGO%2BBl1FQlpvFAt%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Defend against -ffast-math in meson builds
  In-Reply-To: <abGPko4lPv/[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox