public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Corey Huinker <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: [email protected]
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date: Mon, 16 Mar 2026 17:52:38 -0500
Message-ID: <abiJtpb6FsluRpGk@nathan> (raw)
In-Reply-To: <[email protected]>
References: <CADkLM=d-yUR8JsM-UmCfeRAhVj+X9MYi0kz9=zQO4EoBkd8H8A@mail.gmail.com>
<CAA5RZ0tiL01rYm7=WaDGLUYjvz+fQRqmaXyRUv9jKRnR3_6xDQ@mail.gmail.com>
<CADkLM=fn=RmBD0-h+yjTxhpLtbK9s_QdvT-HsGtUj+-1N=6s0g@mail.gmail.com>
<CAA5RZ0sf7vYav+Q5GwxGikBZSYUm+4haA5bHC0N67ct570HLcg@mail.gmail.com>
<abRugSlNTmW0-9Um@nathan>
<CADkLM=cfpFMpgOGPEyr7U+-Cxzvukap-_s8p-ijMTyRphP=oeg@mail.gmail.com>
<abhXqx-xffsknv3B@nathan>
<CADkLM=cuwGZU0i51vn+SUqptXB8QT8rhRRYshns+pX0KxczmAQ@mail.gmail.com>
<abhk0oLSA7lQ62jJ@nathan>
<[email protected]>
On Tue, Mar 17, 2026 at 06:49:17AM +0900, Michael Paquier wrote:
> On Mon, Mar 16, 2026 at 03:15:14PM -0500, Nathan Bossart wrote:
>> On Mon, Mar 16, 2026 at 04:04:23PM -0400, Corey Huinker wrote:
>>> expr_attnum was something that Michael Paquier had lamented that the view
>>> didn't have. There is obviously no present need for it, as pg_dump isn't
>>> being modified for extended stats at all.
>>
>> Okay. I think I'll continue to leave this one out for now.
>
> Lamenting is the right term. The expressions stored in an extended
> stats object have attnumbers computed by the backend, starting from -1
> and decremented, and we don't expose this information at all in any
> system view. It could have helped in enforcing a stronger ordering of
> the items dumps for the extstats restore functions. I still think
> that it could provide an extra layer of safety. Now, we don't
> critically require it either based on how we pass down the input
> arrays, how we dump the data from the catalogs, and how we treat the
> order of the items given as function args.
FTR I'm not mortally opposed to the idea. I just want to get the easier
stuff out of the way first so we can commit the pg_dump change. Then we
can give expr_attnum our undivided attention.
--
nathan
view thread (36+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
In-Reply-To: <abiJtpb6FsluRpGk@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox