public inbox for [email protected]  

help / color / mirror / Atom feed

From: Mark Wong <[email protected]>
To: Andreas Karlsson <[email protected]>
Cc: [email protected]
Subject: Re: updates for handling optional argument in system functions
Date: Wed, 8 Apr 2026 11:10:55 -0700
Message-ID: <adaaL5VD9bfipZQI@ltdrgnflg2> (raw)
In-Reply-To: <[email protected]>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
	<ac63G6p1LAdbsca0@ltdrgnflg2>
	<[email protected]>
	<adWWX4jFbxib8oQ1@ltdrgnflg2>
	<[email protected]>

On Wed, Apr 08, 2026 at 01:51:30AM +0200, Andreas Karlsson wrote:
> On 4/8/26 1:42 AM, Mark Wong wrote:
> > I don't see any matches when I grep for rule_oid or pretty_bool...
> 
> Sorry for the noise, I was looking at an old version of the docs. The 
> parameters do indeed match the docs. But now that I looked at the 
> patches again I found a real issue which I think should be fixed.

No worries.

> I think the following:
> 
> "select statement of a view with pretty-print option"
> 
> should likely just be:
> 
> "select statement of a view"

Yeah, I agree with that considering that other functions like the recent
get_*_ddl functions have options like that aren't detailed in
pg_proc.dat.

What I pondered over a little bit was whether to flip-flop and remove
the original _ext definitions instead and modify their respective
counterparts that I originally removed. I opted to continue editing what
I started because of the comment that reads "System-view support
functions with pretty-print option", but I don't have any strong
opinions either way.

I've attached v7 with the more succinct descriptions.

Regards,
Mark

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: updates for handling optional argument in system functions
  In-Reply-To: <adaaL5VD9bfipZQI@ltdrgnflg2>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox