pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: satyanarlapuram@gmail.com, pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
Date: Wed, 8 Apr 2026 16:19:57 -0500
Message-ID: <adbGfTMw8BiHDMnM@nathan> (raw )
In-Reply-To: <3101163.1775676098@sss.pgh.pa.us >
References: <CAA5RZ0tYzPDeXbqz9uKacRV2xjD055qrg=s3w2PEQPK8EruuSg@mail.gmail.com >
<adFiCgN22xJ7Z-oR@nathan >
<CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com >
<adQsdvPPNviWMCXb@nathan >
<5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com >
<3077290.1775668665@sss.pgh.pa.us >
<adaWuTR7oCKodH7k@nathan >
<3097984.1775674400@sss.pgh.pa.us >
<adan_E0o69p81lIj@nathan >
<3101163.1775676098@sss.pgh.pa.us >
On Wed, Apr 08, 2026 at 03:21:38PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> FWIW that elog() shouldn't be emitting anything from the view, unless
>> something is broken.
>
> [ looks again... ] Oh, you mean because pg_stat_get_autovacuum_scores
> passes 0 for elevel instead of any of the valid elevel constants.
> Can you say "undocumented cowboy hack"? I'd be happier if we added
> something like "#define LOG_NEVER 0 /* Never emit this message */"
> to elog.h and used that.
Yeah... I should've done that originally. Here's a patch that I'll apply
in the next day or so, barring objections.
--
nathan
From 1ce7c01b3e7f594749c4f5edb6e9c14729337779 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Wed, 8 Apr 2026 16:19:33 -0500
Subject: [PATCH 1/1] add LOG_NEVER
---
src/backend/postmaster/autovacuum.c | 3 ++-
src/include/utils/elog.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
index bd626a16363..f9fa874b79f 100644
--- a/src/backend/postmaster/autovacuum.c
+++ b/src/backend/postmaster/autovacuum.c
@@ -3676,7 +3676,8 @@ pg_stat_get_autovacuum_scores(PG_FUNCTION_ARGS)
avopts = extract_autovac_opts(tup, RelationGetDescr(rel));
relation_needs_vacanalyze(form->oid, avopts, form,
- effective_multixact_freeze_max_age, 0,
+ effective_multixact_freeze_max_age,
+ LOG_NEVER,
&dovacuum, &doanalyze, &wraparound,
&scores);
if (avopts)
diff --git a/src/include/utils/elog.h b/src/include/utils/elog.h
index 440a02dd147..9c1e75c59ac 100644
--- a/src/include/utils/elog.h
+++ b/src/include/utils/elog.h
@@ -23,6 +23,7 @@ struct Node;
/* Error level codes */
+#define LOG_NEVER 0 /* Never emit this message */
#define DEBUG5 10 /* Debugging messages, in categories of
* decreasing detail. */
#define DEBUG4 11
--
2.50.1 (Apple Git-155)
Attachments:
[text/plain] 0001-add-LOG_NEVER.patch (1.3K, ../adbGfTMw8BiHDMnM@nathan/2-0001-add-LOG_NEVER.patch)
download | inline diff:
From 1ce7c01b3e7f594749c4f5edb6e9c14729337779 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Wed, 8 Apr 2026 16:19:33 -0500
Subject: [PATCH 1/1] add LOG_NEVER
---
src/backend/postmaster/autovacuum.c | 3 ++-
src/include/utils/elog.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
index bd626a16363..f9fa874b79f 100644
--- a/src/backend/postmaster/autovacuum.c
+++ b/src/backend/postmaster/autovacuum.c
@@ -3676,7 +3676,8 @@ pg_stat_get_autovacuum_scores(PG_FUNCTION_ARGS)
avopts = extract_autovac_opts(tup, RelationGetDescr(rel));
relation_needs_vacanalyze(form->oid, avopts, form,
- effective_multixact_freeze_max_age, 0,
+ effective_multixact_freeze_max_age,
+ LOG_NEVER,
&dovacuum, &doanalyze, &wraparound,
&scores);
if (avopts)
diff --git a/src/include/utils/elog.h b/src/include/utils/elog.h
index 440a02dd147..9c1e75c59ac 100644
--- a/src/include/utils/elog.h
+++ b/src/include/utils/elog.h
@@ -23,6 +23,7 @@ struct Node;
/* Error level codes */
+#define LOG_NEVER 0 /* Never emit this message */
#define DEBUG5 10 /* Debugging messages, in categories of
* decreasing detail. */
#define DEBUG4 11
--
2.50.1 (Apple Git-155)
view thread (61+ messages) latest in thread
Message-ID: <adbGfTMw8BiHDMnM@nathan>
Permalink: ../adbGfTMw8BiHDMnM@nathan/
Also on: postgresql.org/message-id/adbGfTMw8BiHDMnM@nathan
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, exclusion@gmail.com, samimseih@gmail.com, bharath.rupireddyforpostgres@gmail.com, rob@xzilla.net, tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
In-Reply-To: <adbGfTMw8BiHDMnM@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox