From: Alexander Lakhin <exclusion@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
To: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: broken master regress tests
Date: Thu, 28 Dec 2023 18:00:00 +0300
Message-ID: <ae73f6f5-8221-c112-4640-5cda812a69de@gmail.com> (raw)
In-Reply-To: <c6571aac4c6da3e2f013fe74fcc95d6e052bf04c.camel@j-davis.com>
References: <CA+hUKG+VkcevnqLmbZSD4C5hJ3=TQWgMP-th8LqsbNt0TqZfqw@mail.gmail.com>
<20230829155424.bem25upvaefkqqyy@alvherre.pgsql>
<20230912022358.d5ln25sglrntwaia@awork3.anarazel.de>
<0d47e5ecc037b3908149aad5f2a987793cf938bd.camel@j-davis.com>
<20231011005434.34oc4v4pv6ajqkss@awork3.anarazel.de>
<20231213025619.70.nmisch@google.com>
<97c9d15247c5919b444b2e217b4c886271be0ea5.camel@j-davis.com>
<c6571aac4c6da3e2f013fe74fcc95d6e052bf04c.camel@j-davis.com>
Hello Jeff,
22.12.2023 02:17, Jeff Davis wrote:
> On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
>> Attached.
> It appears to increase the coverage. I committed it and I'll see how
> the buildfarm reacts.
Starting from the commit 8793c6005, I observe a failure of test
collate.windows.win1252 on Windows Server 2016:
meson test regress/regress
1/1 postgresql:regress / regress/regress ERROR 24.47s exit status 1
regression.diffs contains:
@@ -993,6 +993,8 @@
-- nondeterministic collations
-- (not supported with libc provider)
CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
+ERROR: could not create locale "en_US": No such file or directory
+DETAIL: The operating system could not find any locale data for the locale name "en_US".
CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
ERROR: nondeterministic collations not supported with this provider
-- cleanup
Though
CREATE COLLATION ctest_det (locale = 'English_United States', deterministic = true);
executed successfully on this OS.
AFAICS, before that commit SELECT getdatabaseencoding() in the test
returned SQL_ASCII, hence the test was essentially skipped, but now it
returns WIN1252, so problematic CREATE COLLATION(locale = 'en_US', ...)
is reached.
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, pgsql@j-davis.com, noah@leadboat.com, andres@anarazel.de, alvherre@alvh.no-ip.org, thomas.munro@gmail.com, pavel.stehule@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: broken master regress tests
In-Reply-To: <ae73f6f5-8221-c112-4640-5cda812a69de@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox