public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Dean Rasheed <[email protected]>
Subject: Re: Virtual generated columns
Date: Tue, 14 Jan 2025 10:58:20 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxENbbA_LCnDLd=y3t+mqvcPyQNW__qw3VYQwq3Tkc_JSg@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
	<[email protected]>
	<CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CACJufxF8fmM=Dbm4pDFuV_nKGz2-No0k4YifhrF3-rjXTWJM3w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CACJufxEeUfpUoFng=0Pm0-cJ4rwyBJCv4x_FXmkYqozWB7uvFQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CACJufxENbbA_LCnDLd=y3t+mqvcPyQNW__qw3VYQwq3Tkc_JSg@mail.gmail.com>

On 09.01.25 13:41, jian he wrote:
> we can not ALTER COLUMN DROP EXPRESSION for virtual for now.
> so the following comments in generated_virtual.sql conflict with the output.
> ```
> -- check that dependencies between columns have also been removed
> ALTER TABLE gtest29 DROP COLUMN a;  -- should not drop b
> \d gtest29
> ```
> we can also comment out line 557 in generated_virtual.sql.

Ok will do.

> attach patch is removing unnecessary parentheses from
> ```ereport(ERROR, (errcode```
> only for this patch related.
> per commit https://git.postgresql.org/cgit/postgresql.git/commit/?id=e3a87b4991cc2d00b7a3082abb54c5f12baedfd1
> 
> also https://www.postgresql.org/docs/current/error-message-reporting.html says
>   ""The extra parentheses were required before PostgreSQL version 12,
> but are now optional.""

Right.  I tried to keep it mostly consistent with existing surrounding 
code, but I will do another pass to improve that.

view thread (75+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Virtual generated columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox