pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Kirill Reshke <reshkekirill@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: relfilenode statistics
Date: Sat, 11 Jul 2026 19:10:10 +0900
Message-ID: <alIWgtRb_ZMiCMFf@paquier.xyz> (raw)
In-Reply-To: <alHDjQcMJKGhE2l3@bdtpg>
References: <ezbfcpjtfh3vtm667aegyrptcdsvinbuxw6y5p6j3e5fbffrl5@i7v6cjapz3yv>
	<aUELPdhdcyzTM_8K@paquier.xyz>
	<zferux2jlbhqymubzhpubfrkjzhzxzguq4eprtycojtif5vbqh@2t7cu2teyqmi>
	<aWYQXiKgIIvrlyVi@ip-10-97-1-34.eu-west-3.compute.internal>
	<aZv2B8CFJZTKEl8j@ip-10-97-1-34.eu-west-3.compute.internal>
	<aa56L2wM16VldK5f@ip-10-97-1-34.eu-west-3.compute.internal>
	<alCLr8ya-4ojew-x@paquier.xyz>
	<74242uhjpufa2tsb6dqot7cvhhyxjbhfo273wpooo6hizbdg6o@f45d72gt2ujb>
	<alG8F9lVldB3WseN@paquier.xyz>
	<alHDjQcMJKGhE2l3@bdtpg>

On Sat, Jul 11, 2026 at 04:16:13AM +0000, Bertrand Drouvot wrote:
> Maybe resume this thread [1] instead of creating a new one? It's in this thread
> that it has been suggested to start with relfilenode stats first [2] but that
> was due to the design of the patch at that time that may not apply to yours (did
> not look at it yet).
> 
> [1]: https://postgr.es/m/f572abe7-a1bb-e13b-48c7-2ca150546822%40gmail.com
> [2]: https://postgr.es/m/20230105002733.ealhzubjaiqis6ua%40awork3.anarazel.de

Honestly, I don't know which way is the best.  This was 3 years ago so
starting afresh may be better at the end.  Please note that I have
spent a couple of hours eyeing at your previous patch, where I'd like
to think that I have found an approach with a better balance,
finishing by being less invasive.  The two main points are 1) the
handling of the xact data for a split for the fields we care about and
2) a union structure felt less intrusive, but these two points really
come down to where you want to put a separation line.  Another side thing
is the renaming of the SQL functions for non-index relkinds, your
patch using *_tab_*.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../alIWgtRb_ZMiCMFf@paquier.xyz/2-signature.asc)
  download

view thread (64+ messages)  latest in thread

Message-ID: <alIWgtRb_ZMiCMFf@paquier.xyz>
Permalink:  ../alIWgtRb_ZMiCMFf@paquier.xyz/
Also on:    postgresql.org/message-id/alIWgtRb_ZMiCMFf@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, bertranddrouvot.pg@gmail.com, andres@anarazel.de, reshkekirill@gmail.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: relfilenode statistics
  In-Reply-To: <alIWgtRb_ZMiCMFf@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox