agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: Anton Voloshin <a.voloshin@postgrespro.ru>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and -DEXEC_BACKEND at startup
Date: Wed, 15 Jul 2026 18:14:30 +0200
Message-ID: <alew9Lk3BXiGZsm7@alvherre.pgsql> (raw)
In-Reply-To: <4ccb96f8-0bac-4362-ac22-2f81d1b0062c@postgrespro.ru>
On 2026-Jul-15, Anton Voloshin wrote:
> On 08/06/2026 21:03, Álvaro Herrera wrote:
>
> > --- a/src/include/postmaster/syslogger.h
> > +++ b/src/include/postmaster/syslogger.h
> > @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2];
> > extern PGDLLIMPORT HANDLE syslogPipe[2];
> > #endif
> >
> > +extern bool syslogger_setup_done;
>
> Shouldn't this be extern *PGDLLIMPORT* bool ... ?
Hmm, does that export the symbol so that third-party code can get at it?
I'm not sure it makes sense to do it for this one symbol, which should
be internal business between syslogger and elog only.
Did you hit a problem with it? If so, what was it?
Michael, looking at
https://github.com/michaelpq/pg_plugins/blob/main/jsonlog/jsonlog.c
do you see an issue with this variable?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La espina, desde que nace, ya pincha" (Proverbio africano)
view thread (25+ messages) latest in thread
Message-ID: <alew9Lk3BXiGZsm7@alvherre.pgsql>
Permalink: ../alew9Lk3BXiGZsm7@alvherre.pgsql/
Also on: postgresql.org/message-id/alew9Lk3BXiGZsm7@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, a.voloshin@postgrespro.ru, michael@paquier.xyz, euler@eulerto.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and -DEXEC_BACKEND at startup
In-Reply-To: <alew9Lk3BXiGZsm7@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox