pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Cc: Kevin Grittner <kgrittn@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors
Date: Fri, 14 Jul 2017 14:06:10 +0200 (CEST)
Message-ID: <alpine.DEB.2.20.1707141400480.20175@lancre> (raw)
In-Reply-To: <db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru>
References: <72a0d590d6ba06f242d75c2e641820ec@postgrespro.ru>
	<alpine.DEB.2.20.1707011607370.6840@lancre>
	<6b4a7fb36c9956595a89a08e5368a9c5@postgrespro.ru>
	<alpine.DEB.2.20.1707031321370.3419@lancre>
	<01df6ca86c78e2c80b4e4d021c99d53a@postgrespro.ru>
	<alpine.DEB.2.20.1707031430380.15247@lancre>
	<f69d534dfada1fdb4767496b7ffc007f@postgrespro.ru>
	<alpine.DEB.2.20.1707121142300.12795@lancre>
	<alpine.DEB.2.20.1707121338090.12795@lancre>
	<898b57f7c12b6bd0484f8ca58fdf8436@postgrespro.ru>
	<alpine.DEB.2.20.1707131833150.20175@lancre>
	<db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>


>> Note that there is something for psql (src/bin/psql/variable.c) which 
>> may or may not be shared. It should be checked before recoding 
>> eventually the same thing.
>
> Thank you very much for pointing this file! As I checked this is another 
> structure: here there's a simple list, while in pgbench we should know 
> if the list is sorted and the number of elements in the list. How do you 
> think, is it a good idea to name a variables structure in pgbench in the 
> same way (VariableSpace) or it should be different not to be confused 
> (Variables, for example)?

Given that the number of variables of a pgbench script is expected to be 
pretty small, I'm not sure that the sorting stuff is worth the effort.

My suggestion is really to look at both implementations and to answer the 
question "should pgbench share its variable implementation with psql?".

If the answer is yes, then the relevant part of the implementation should 
be moved to fe_utils, and that's it.

If the answer is no, then implement something in pgbench directly.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (137+ messages)  latest in thread

Message-ID: <alpine.DEB.2.20.1707141400480.20175@lancre>
Permalink:  ../alpine.DEB.2.20.1707141400480.20175@lancre/
Also on:    postgresql.org/message-id/alpine.DEB.2.20.1707141400480.20175@lancre

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, m.polyakova@postgrespro.ru, kgrittn@gmail.com, andres@anarazel.de, alvherre@2ndquadrant.com, thomas.munro@enterprisedb.com, robertmhaas@gmail.com
  Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors
  In-Reply-To: <alpine.DEB.2.20.1707141400480.20175@lancre>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox