pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Cc: Kevin Grittner <kgrittn@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors
Date: Fri, 14 Jul 2017 13:36:02 +0300
Message-ID: <db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru> (raw)
In-Reply-To: <alpine.DEB.2.20.1707131833150.20175@lancre>
References: <72a0d590d6ba06f242d75c2e641820ec@postgrespro.ru>
	<alpine.DEB.2.20.1707011607370.6840@lancre>
	<6b4a7fb36c9956595a89a08e5368a9c5@postgrespro.ru>
	<alpine.DEB.2.20.1707031321370.3419@lancre>
	<01df6ca86c78e2c80b4e4d021c99d53a@postgrespro.ru>
	<alpine.DEB.2.20.1707031430380.15247@lancre>
	<f69d534dfada1fdb4767496b7ffc007f@postgrespro.ru>
	<alpine.DEB.2.20.1707121142300.12795@lancre>
	<alpine.DEB.2.20.1707121338090.12795@lancre>
	<898b57f7c12b6bd0484f8ca58fdf8436@postgrespro.ru>
	<alpine.DEB.2.20.1707131833150.20175@lancre>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

>>> I was not convinced by the overall memory management around variables
>>> to begin with, and it is even less so with their new copy management.
>>> Maybe having a clean "Variables" data structure could help improve 
>>> the
>>> situation.
> 
> Note that there is something for psql (src/bin/psql/variable.c) which
> may or may not be shared. It should be checked before recoding
> eventually the same thing.

Thank you very much for pointing this file! As I checked this is another 
structure: here there's a simple list, while in pgbench we should know 
if the list is sorted and the number of elements in the list. How do you 
think, is it a good idea to name a variables structure in pgbench in the 
same way (VariableSpace) or it should be different not to be confused 
(Variables, for example)?

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (137+ messages)  latest in thread

Message-ID: <db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru>
Permalink:  ../db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru/
Also on:    postgresql.org/message-id/db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: m.polyakova@postgrespro.ru, coelho@cri.ensmp.fr, kgrittn@gmail.com, andres@anarazel.de, alvherre@2ndquadrant.com, thomas.munro@enterprisedb.com, robertmhaas@gmail.com
  Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors
  In-Reply-To: <db67776a7d4bc4e16bd9ff689d15c480@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox