pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Ildar Musin <i.musin@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: General purpose hashing func in pgbench
Date: Sun, 28 Jan 2018 09:10:11 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1801280851260.17596@lancre> (raw)
In-Reply-To: <12986cad-3dd9-a449-e318-4acd8a8e1697@postgrespro.ru>
References: <0e8bd39e-dfcd-2879-f88f-272799ad7ef2@postgrespro.ru>
	<38f1503e-7b63-4612-24a9-041af25bb022@postgrespro.ru>
	<alpine.DEB.2.20.1712251506160.22976@lancre>
	<af1ccd41-dcd0-f56b-0a05-a558da54762b@postgrespro.ru>
	<alpine.DEB.2.20.1712251702170.22976@lancre>
	<9603bac9-ae5d-36c5-5978-a88bdb700e37@postgrespro.ru>
	<alpine.DEB.2.20.1801092000230.2326@hendaye>
	<63f5a6ac-0c5b-8d59-ca8b-fc8e11244a66@postgrespro.ru>
	<alpine.DEB.2.20.1801101903150.15856@lancre>
	<291822a3-0b3a-0b21-c694-c10776f516ac@postgrespro.ru>
	<6e47c84a-d42a-0e08-1b0d-33e6a6c87778@postgrespro.ru>
	<alpine.DEB.2.20.1801121614470.13422@lancre>
	<bca39e87-6d40-98f6-e4ef-e2d88e109f9c@postgrespro.ru>
	<alpine.DEB.2.20.1801170727240.11884@lancre>
	<960a8096-dde5-5175-7d7c-ef151086cbee@postgrespro.ru>
	<alpine.DEB.2.20.1801180710400.11884@lancre>
	<ae0c93b1-f8a8-a9aa-244c-0c872fa789f0@postgrespro.ru>
	<alpine.DEB.2.20.1801260714070.26762@lancre>
	<12986cad-3dd9-a449-e318-4acd8a8e1697@postgrespro.ru>


Hello Ildar,

> I did everything you mention here and attached a new version on the patch.

Patch applies, compiles, runs ok.

Alas, I still have a few more very minor comments about the doc, sorry 
again:

   +       <entry> <literal>default_seed</literal> </entry>
   +       <entry>random seed used in hash functions by default</entry>

s/random //: the seed may or may not be random.

The "In some cases several distinct distributions..." paragraph is also 
just one line in the xml source file. It should be justified at about 80 
columns like others.

-- 
Fabien.




view thread (44+ messages)  latest in thread

Message-ID: <alpine.DEB.2.20.1801280851260.17596@lancre>
Permalink:  ../alpine.DEB.2.20.1801280851260.17596@lancre/
Also on:    postgresql.org/message-id/alpine.DEB.2.20.1801280851260.17596@lancre

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, i.musin@postgrespro.ru
  Subject: Re: General purpose hashing func in pgbench
  In-Reply-To: <alpine.DEB.2.20.1801280851260.17596@lancre>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox