pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Rady, Doug <radydoug@amazon.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
Date: Mon, 29 Jan 2018 09:58:59 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1801290953280.31442@lancre> (raw)
In-Reply-To: <654A1247-8E1E-4E9C-937D-9119B1731FF2@amazon.com>
References: <23D017C9-81B7-484D-8490-FD94DEC4DF59@amazon.com>
	<alpine.DEB.2.20.1801240847010.2307@lancre>
	<16744C85-E44E-4354-9E3D-45A7C9BDB19B@amazon.com>
	<alpine.DEB.2.20.1801252339520.26762@lancre>
	<81936381-841A-459D-9FE5-18659680355C@amazon.com>
	<alpine.DEB.2.20.1801262348420.17596@lancre>
	<654A1247-8E1E-4E9C-937D-9119B1731FF2@amazon.com>


Hello Doug,

>    I'm not sure why you do the following trick, could you explain?
>       +#undef USE_SELECT
>       +#define USE_SELECT
>
> This was due to compiler complaint about USE_SELECT being redefined.
> Have replaced that "trick" with a new #define POLL_USING_SELECT which is used elsewhere in pgbench instead.

Ok, why not.

Another option to avoid the warning and a new name could have been to 
"#ifndef X #define X #endif /* !X */"

Patch applies cleanly, compiles cleanly for both options, local & global 
"make check" ok.

Switched to "Ready".

-- 
Fabien.




view thread (51+ messages)  latest in thread

Message-ID: <alpine.DEB.2.20.1801290953280.31442@lancre>
Permalink:  ../alpine.DEB.2.20.1801290953280.31442@lancre/
Also on:    postgresql.org/message-id/alpine.DEB.2.20.1801290953280.31442@lancre

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, radydoug@amazon.com, robertmhaas@gmail.com
  Subject: Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
  In-Reply-To: <alpine.DEB.2.20.1801290953280.31442@lancre>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox