From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade: Error out on too many command-line arguments
Date: Fri, 30 Aug 2019 16:55:05 +0200 (CEST)
Message-ID: <alpine.DEB.2.21.1908301651290.28828@lancre> (raw)
In-Reply-To: <24927.1567176468@sss.pgh.pa.us>
References: <f2554627-04e7-383a-ef01-ab99bb6a291c@2ndquadrant.com>
<12750.1566743399@sss.pgh.pa.us>
<CAOBaU_a5kYkR5gV7nCwjY_ZxahzM95=XACSLwg3gd7L59K3JAA@mail.gmail.com>
<20190826044317.GC7005@paquier.xyz>
<CALtqXTfTqTsrG4s4rHbHFE9bMwpgX7QWsDuD-hG1yX3BcJD_8Q@mail.gmail.com>
<2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com>
<alpine.DEB.2.21.1908300842470.28828@lancre>
<15110.1567173253@sss.pgh.pa.us>
<alpine.DEB.2.21.1908301622100.28828@lancre>
<24927.1567176468@sss.pgh.pa.us>
>>> Is this issue *really* worth expending test cycles on forevermore?
>
>> With this argument consistently applied, postgres code coverage is
>> consistently weak, with 25% of the code never executed, and 15% of
>> functions never called. "psql" is abysmal, "libpq" is really weak.
>
> It's all a question of balance. If you go too far in the other
> direction, you end up with test suites that take an hour and a half
> to run so nobody ever runs them (case in point, mysql). I'm all for
> improving coverage in meaningful ways --- but cases like this seem
> unlikely to be worth ongoing expenditures of testing effort.
Sure.
I think there is room for several classes of tests, important ones always
run and others run say by the farm, and I thought that is what TAP tests
were for, given they are quite expensive anyway (eg most TAP test create
their own postgres instance).
So for me the suggestion was appropriate for a pgbench-specific TAP test.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, ibrar.ahmad@gmail.com, michael@paquier.xyz, rjuju123@gmail.com
Subject: Re: pg_upgrade: Error out on too many command-line arguments
In-Reply-To: <alpine.DEB.2.21.1908301651290.28828@lancre>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox