From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade: Error out on too many command-line arguments
Date: Fri, 30 Aug 2019 08:44:28 +0200 (CEST)
Message-ID: <alpine.DEB.2.21.1908300842470.28828@lancre> (raw)
In-Reply-To: <2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com>
References: <f2554627-04e7-383a-ef01-ab99bb6a291c@2ndquadrant.com>
<12750.1566743399@sss.pgh.pa.us>
<CAOBaU_a5kYkR5gV7nCwjY_ZxahzM95=XACSLwg3gd7L59K3JAA@mail.gmail.com>
<20190826044317.GC7005@paquier.xyz>
<CALtqXTfTqTsrG4s4rHbHFE9bMwpgX7QWsDuD-hG1yX3BcJD_8Q@mail.gmail.com>
<2a70fc23-3545-d22d-2071-a42ee18757c9@2ndquadrant.com>
Hello Peter,
>> On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote:
>> > I did some searching, and oid2name.c is also missing this.
>>
>> And pgbench, no?
>>
>> Yes, the patch is slightly different.
>
> Thanks, pushed all that together.
Great!
Could we maintain coverage by adding a TAP test? See 1 liner attached.
--
Fabien.
Attachments:
[text/x-diff] pgbench-too-many-1.patch (461B, ../alpine.DEB.2.21.1908300842470.28828@lancre/2-pgbench-too-many-1.patch)
download | inline diff:diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.plindex f7fa18418b..912312b7ca 100644--- a/src/bin/pgbench/t/002_pgbench_no_server.pl+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl@@ -157,6 +157,7 @@ my @options = (
qr{error while setting random seed from --random-seed option}
]
],
+ [ 'too many args', 'dbname foo', [ qr{too many .*first is "foo"} ] ],
# logging sub-options
[
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, peter.eisentraut@2ndquadrant.com, ibrar.ahmad@gmail.com, michael@paquier.xyz, rjuju123@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pg_upgrade: Error out on too many command-line arguments
In-Reply-To: <alpine.DEB.2.21.1908300842470.28828@lancre>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox