pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Vik Fearing <vik.fearing@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
Date: Wed, 29 Jan 2020 08:25:08 +0100 (CET)
Message-ID: <alpine.DEB.2.21.2001271250190.24374@pseudo> (raw)
In-Reply-To: <e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
References: <09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com>
	<alpine.DEB.2.21.2001261946530.29788@pseudo>
	<e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>


Hello Vik,

>> Isn't there examples in the documentation which use the default prompts?
>>
>> If so, should they be updated accordingly?
>
> Good catch!
> I thought about the documentation but not the examples therein.
>
> Updated patch attached.

Ok.

Only one transaction prompt example in the whole documentation:-(
No tests is troubled by the change:-(
Sigh…

Patch applies and compiles cleanly, global and psql make check ok.

Doc build ok.

Works for me.

I'd be in favor of adding a non trivial session example in psql 
documentation at the end of the prompt stuff section, something like:

BEGIN;
CREATE TABLE
   Word(data TEXT PRIMARY KEY);
COPY Word(data) FROM STDIN;
hello
\.
SELECT 2+;
ROLLBACK;

but this is not necessary for this patch.

-- 
Fabien.

view thread (23+ messages)  latest in thread

Message-ID: <alpine.DEB.2.21.2001271250190.24374@pseudo>
Permalink:  ../alpine.DEB.2.21.2001271250190.24374@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.21.2001271250190.24374@pseudo

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, vik.fearing@2ndquadrant.com
  Subject: Re: Add %x to PROMPT1 and PROMPT2
  In-Reply-To: <alpine.DEB.2.21.2001271250190.24374@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox