pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
Date: Wed, 6 May 2020 07:36:21 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2005051811320.2183756@pseudo> (raw)
In-Reply-To: <20200505140055.GC21752@momjian.us>
References: <20200505031600.GB21752@momjian.us>
	<alpine.DEB.2.22.394.2005050710540.175044@pseudo>
	<20200505140055.GC21752@momjian.us>


Hello Bruce,

>> * "DOCUMENT THE DEFAULT GENERATION METHOD"
>>   => The default is still to generate data client-side.
>
> My point is that the docs are not clear about this.

Indeed.

> Can you fix it?

Sure. Attached patch adds an explicit sentence about it, as it was only 
hinted about in the default initialization command string, and removes a 
spurious empty paragraph found nearby.

-- 
Fabien.

Attachments:

pgbench-doc-default-g-1.patch (text/x-diff, 1.0K) download
diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index c9a9f0e0e5..ef75e5328c 100644
--- a/doc/src/sgml/ref/pgbench.sgml
+++ b/doc/src/sgml/ref/pgbench.sgml
@@ -198,6 +198,8 @@ pgbench <optional> <replaceable>options</replaceable> </optional> <replaceable>d
            <para>
             Generate data and load it into the standard tables,
             replacing any data already present.
+            Default is to generate data client-side (<literal>g</literal>)
+            and transmit it over the connection.
            </para>
            <para>
             With <literal>g</literal> (client-side data generation),
@@ -218,9 +220,6 @@ pgbench <optional> <replaceable>options</replaceable> </optional> <replaceable>d
             message when generating data into
             <structname>pgbench_accounts</structname> table.
            </para>
-           <para>
-            
-           </para>
           </listitem>
          </varlistentry>
          <varlistentry>

view thread (194+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2005051811320.2183756@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2005051811320.2183756@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2005051811320.2183756@pseudo

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, bruce@momjian.us
  Subject: Re: PG 13 release notes, first draft
  In-Reply-To: <alpine.DEB.2.22.394.2005051811320.2183756@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox