pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: some more pg_dump refactoring
Date: Wed, 8 Jul 2020 06:42:14 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2007080640000.261743@pseudo> (raw)
In-Reply-To: <e6556d43-ded2-9a7b-4536-9a3cf59c796b@2ndquadrant.com>
References: <6594334b-40fd-14f1-6bc5-877afa3feed5@2ndquadrant.com>
	<alpine.DEB.2.22.394.2006250820020.2939276@pseudo>
	<458c97a0-1841-88c9-eddf-a45a8ba86811@2ndquadrant.com>
	<alpine.DEB.2.22.394.2006300853470.1117309@pseudo>
	<e6556d43-ded2-9a7b-4536-9a3cf59c796b@2ndquadrant.com>


Hallo Peter,

>>>> Would it make sense to accumulate in the other direction, older to newer,
>>>> so that new attributes are added at the end of the select?
>>> I think that could make sense, but the current style was introduced by
>>> daa9fe8a5264a3f192efa5ddee8fb011ad9da365.  Should we revise that?
>> It seems to me more logical to do it while you're at it, but you are the
>> one writing the patches:-)
>
> What do you think about this patch to reorganize the existing code from that 
> old commit?

I think it is a definite further improvement.

Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to 
me.

-- 
Fabien.





view thread (10+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2007080640000.261743@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2007080640000.261743@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2007080640000.261743@pseudo

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, peter.eisentraut@2ndquadrant.com
  Subject: Re: some more pg_dump refactoring
  In-Reply-To: <alpine.DEB.2.22.394.2007080640000.261743@pseudo>
  References: <6594334b-40fd-14f1-6bc5-877afa3feed5@2ndquadrant.com> <alpine.DEB.2.22.394.2006250820020.2939276@pseudo> <458c97a0-1841-88c9-eddf-a45a8ba86811@2ndquadrant.com> <alpine.DEB.2.22.394.2006300853470.1117309@pseudo> <e6556d43-ded2-9a7b-4536-9a3cf59c796b@2ndquadrant.com> <alpine.DEB.2.22.394.2007080640000.261743@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox