pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: some more pg_dump refactoring
Date: Wed, 15 Jul 2020 15:05:32 +0200
Message-ID: <45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com> (raw)
In-Reply-To: <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com>
References: <6594334b-40fd-14f1-6bc5-877afa3feed5@2ndquadrant.com>
	<alpine.DEB.2.22.394.2006250820020.2939276@pseudo>
	<458c97a0-1841-88c9-eddf-a45a8ba86811@2ndquadrant.com>
	<alpine.DEB.2.22.394.2006300853470.1117309@pseudo>
	<e6556d43-ded2-9a7b-4536-9a3cf59c796b@2ndquadrant.com>
	<alpine.DEB.2.22.394.2007080640000.261743@pseudo>
	<68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com>

On 2020-07-09 16:14, Peter Eisentraut wrote:
> On 2020-07-08 06:42, Fabien COELHO wrote:
>>> What do you think about this patch to reorganize the existing code from that
>>> old commit?
>>
>> I think it is a definite further improvement.
>>
>> Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to
>> me.
> 
> Thanks.  I have committed that, and attached is my original patch
> adjusted to this newer style.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (10+ messages)

Message-ID: <45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com>
Permalink:  ../45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com/
Also on:    postgresql.org/message-id/45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, coelho@cri.ensmp.fr
  Subject: Re: some more pg_dump refactoring
  In-Reply-To: <45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com>
  References: <6594334b-40fd-14f1-6bc5-877afa3feed5@2ndquadrant.com> <alpine.DEB.2.22.394.2006250820020.2939276@pseudo> <458c97a0-1841-88c9-eddf-a45a8ba86811@2ndquadrant.com> <alpine.DEB.2.22.394.2006300853470.1117309@pseudo> <e6556d43-ded2-9a7b-4536-9a3cf59c796b@2ndquadrant.com> <alpine.DEB.2.22.394.2007080640000.261743@pseudo> <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com> <45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox